Software /
code /
prosody
File
net/tls_luasec.lua @ 12659:c0eea4f6c739
usermanager: Add back temporary is_admin to warn about deprecated API usage
Goal: Introduce role-auth with minimal disruption
is_admin() is unsafe in a system with per-session permissions, so it has been
deprecated.
Roll-out approach:
1) First, log a warning when is_admin() is used. It should continue to
function normally, backed by the new role API. Nothing is really using
per-session authz yet, so there is minimal security concern.
The 'strict_deprecate_is_admin' global setting can be set to 'true' to
force a hard failure of is_admin() attempts (it will log an error and
always return false).
2) In some time (at least 1 week), but possibly longer depending on the number
of affected deployments: switch 'strict_deprecate_is_admin' to 'true' by
default. It can still be disabled for systems that need it.
3) Further in the future, before the next release, the option will be removed
and is_admin() will be permanently disabled.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Mon, 15 Aug 2022 15:25:07 +0100 |
parent | 12486:ee93df086926 |
child | 13115:749376d75b40 |
line wrap: on
line source
-- Prosody IM -- Copyright (C) 2021 Prosody folks -- -- This project is MIT/X11 licensed. Please see the -- COPYING file in the source package for more information. -- --[[ This file provides a shim abstraction over LuaSec, consolidating some code which was previously spread between net.server backends, portmanager and certmanager. The goal is to provide a more or less well-defined API on top of LuaSec which abstracts away some of the things which are not needed and simplifies usage of commonly used things (such as SNI contexts). Eventually, network backends which do not rely on LuaSocket+LuaSec should be able to provide *this* API instead of having to mimic LuaSec. ]] local ssl = require "ssl"; local ssl_newcontext = ssl.newcontext; local ssl_context = ssl.context or require "ssl.context"; local io_open = io.open; local context_api = {}; local context_mt = {__index = context_api}; function context_api:set_sni_host(host, cert, key) local ctx, err = self._builder:clone():apply({ certificate = cert, key = key, }):build(); if not ctx then return false, err end self._sni_contexts[host] = ctx._inner return true, nil end function context_api:remove_sni_host(host) self._sni_contexts[host] = nil end function context_api:wrap(sock) local ok, conn, err = pcall(ssl.wrap, sock, self._inner); if not ok then return nil, err end return conn, nil end local function new_context(cfg, builder) -- LuaSec expects dhparam to be a callback that takes two arguments. -- We ignore those because it is mostly used for having a separate -- set of params for EXPORT ciphers, which we don't have by default. if type(cfg.dhparam) == "string" then local f, err = io_open(cfg.dhparam); if not f then return nil, "Could not open DH parameters: "..err end local dhparam = f:read("*a"); f:close(); cfg.dhparam = function() return dhparam; end end local inner, err = ssl_newcontext(cfg); if not inner then return nil, err end -- COMPAT Older LuaSec ignores the cipher list from the config, so we have to take care -- of it ourselves (W/A for #x) if inner and cfg.ciphers then local success; success, err = ssl_context.setcipher(inner, cfg.ciphers); if not success then return nil, err end end return setmetatable({ _inner = inner, _builder = builder, _sni_contexts = {}, }, context_mt), nil end return { new_context = new_context, };