File

net.server_epoll: Call :shutdown() on TLS sockets when supported Comment from Matthew: This fixes a potential issue where the Prosody process gets blocked on sockets waiting for them to close. Unlike non-TLS sockets, closing a TLS socket sends layer 7 data, and this can cause problems for sockets which are in the process of being cleaned up. This depends on LuaSec changes which are not yet upstream. From Martijn's original email: So first my analysis of luasec. in ssl.c the socket is put into blocking mode right before calling SSL_shutdown() inside meth_destroy(). My best guess to why this is is because meth_destroy is linked to the __close and __gc methods, which can't exactly be called multiple times and luasec does want to make sure that a tls session is shutdown as clean as possible. I can't say I disagree with this reasoning and don't want to change this behaviour. My solution to this without changing the current behaviour is to introduce a shutdown() method. I am aware that this overlaps in a conflicting way with tcp's shutdown method, but it stays close to the OpenSSL name. This method calls SSL_shutdown() in the current (non)blocking mode of the underlying socket and returns a boolean whether or not the shutdown is completed (matching SSL_shutdown()'s 0 or 1 return values), and returns the familiar ssl_ioerror() strings on error with a false for completion. This error can then be used to determine if we have wantread/wantwrite to finalize things. Once meth_shutdown() has been called once a shutdown flag will be set, which indicates to meth_destroy() that the SSL_shutdown() has been handled by the application and it shouldn't be needed to set the socket to blocking mode. I've left the SSL_shutdown() call in the LSEC_STATE_CONNECTED to prevent TOCTOU if the application reaches a timeout for the shutdown code, which might allow SSL_shutdown() to clean up anyway at the last possible moment. Another thing I've changed to luasec is the call to socket_setblocking() right before calling close(2) in socket_destroy() in usocket.c. According to the latest POSIX[0]: Note that the requirement for close() on a socket to block for up to the current linger interval is not conditional on the O_NONBLOCK setting. Which I read to mean that removing O_NONBLOCK on the socket before close doesn't impact the behaviour and only causes noise in system call tracers. I didn't touch the windows bits of this, since I don't do windows. For the prosody side of things I've made the TLS shutdown bits resemble interface:onwritable(), and put it under a combined guard of self._tls and self.conn.shutdown. The self._tls bit is there to prevent getting stuck on this condition, and self.conn.shutdown is there to prevent the code being called by instances where the patched luasec isn't deployed. The destroy() method can be called from various places and is read by me as the "we give up" error path. To accommodate for these unexpected entrypoints I've added a single call to self.conn:shutdown() to prevent the socket being put into blocking mode. I have no expectations that there is any other use here. Same as previous, the self.conn.shutdown check is there to make sure it's not called on unpatched luasec deployments and self._tls is there to make sure we don't call shutdown() on tcp sockets. I wouldn't recommend logging of the conn:shutdown() error inside close(), since a lot of clients simply close the connection before SSL_shutdown() is done.

+
−All source code in this project is released under the below MIT license. Some
+
−components are not authored by the Prosody maintainers, but such code is
+
−itself either released under a MIT license or declared public domain.
+
−
+
−---
+
−
+
−Copyright (C) 2008-2022 Matthew Wild
+
−Copyright (C) 2008-2020 Waqas Hussain
+
−Copyright (C) 2010-2022 Kim Alvefur
+
−
+
−Permission is hereby granted, free of charge, to any person obtaining a copy
+
−of this software and associated documentation files (the "Software"), to deal
+
−in the Software without restriction, including without limitation the rights
+
−to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+
−copies of the Software, and to permit persons to whom the Software is
+
−furnished to do so, subject to the following conditions:
+
−
+
−The above copyright notice and this permission notice shall be included in
+
−all copies or substantial portions of the Software.
+
−
+
−THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+
−EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+
−MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.
+
−IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
+
−CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
+
−TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
+
−SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+
−
+
−---
+
−
+
−util-src/encodings.c:
+
−  Parts included from Lua 5.3. Copyright (C) 1994-2015 Lua.org, PUC-Rio.
+
−
+
−util-src/signal.c:
+
−  Copyright (C) 2007  Patrick J. Donnelly (batrick@batbytes.com)
+
−  See full copyright notice in the source file.
+
−
+
−util-src/struct.c:
+
−  Copyright (C) 2010-2018 Lua.org, PUC-Rio. All rights reserved.
+
−  See full copyright notice in the source file.
+
−
+
−net/dns.lua:
+
−  public domain 20080404 lua@ztact.com
+
−