Software /
code /
prosody
File
spec/scansion/muc_create_destroy.scs @ 12642:9061f9621330
Switch to a new role-based authorization framework, removing is_admin()
We began moving away from simple "is this user an admin?" permission checks
before 0.12, with the introduction of mod_authz_internal and the ability to
dynamically change the roles of individual users.
The approach in 0.12 still had various limitations however, and apart from
the introduction of roles other than "admin" and the ability to pull that info
from storage, not much actually changed.
This new framework shakes things up a lot, though aims to maintain the same
functionality and behaviour on the surface for a default Prosody
configuration. That is, if you don't take advantage of any of the new
features, you shouldn't notice any change.
The biggest change visible to developers is that usermanager.is_admin() (and
the auth provider is_admin() method) have been removed. Gone. Completely.
Permission checks should now be performed using a new module API method:
module:may(action_name, context)
This method accepts an action name, followed by either a JID (string) or
(preferably) a table containing 'origin'/'session' and 'stanza' fields (e.g.
the standard object passed to most events). It will return true if the action
should be permitted, or false/nil otherwise.
Modules should no longer perform permission checks based on the role name.
E.g. a lot of code previously checked if the user's role was prosody:admin
before permitting some action. Since many roles might now exist with similar
permissions, and the permissions of prosody:admin may be redefined
dynamically, it is no longer suitable to use this method for permission
checks. Use module:may().
If you start an action name with ':' (recommended) then the current module's
name will automatically be used as a prefix.
To define a new permission, use the new module API:
module:default_permission(role_name, action_name)
module:default_permissions(role_name, { action_name[, action_name...] })
This grants the specified role permission to execute the named action(s) by
default. This may be overridden via other mechanisms external to your module.
The built-in roles that developers should use are:
- prosody:user (normal user)
- prosody:admin (host admin)
- prosody:operator (global admin)
The new prosody:operator role is intended for server-wide actions (such as
shutting down Prosody).
Finally, all usage of is_admin() in modules has been fixed by this commit.
Some of these changes were trickier than others, but no change is expected to
break existing deployments.
EXCEPT: mod_auth_ldap no longer supports the ldap_admin_filter option. It's
very possible nobody is using this, but if someone is then we can later update
it to pull roles from LDAP somehow.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 15 Jun 2022 12:15:01 +0100 |
parent | 10941:642773f3073b |
line wrap: on
line source
# MUC creation, basic messages and destruction [Client] Romeo jid: romeo@localhost/mK0dD6Ha password: password [Client] Juliet jid: juliet@localhost/lVwkim_k password: password [Client] Admin jid: admin@localhost/DfNgg9VE password: password ----- Romeo connects Romeo sends: <presence to="garden@conference.localhost/romeo"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from="garden@conference.localhost/romeo"> <x xmlns="vcard-temp:x:update"> <photo/> </x> <x xmlns="http://jabber.org/protocol/muc#user"> <status code="201"/> <item affiliation="owner" jid="${Romeo's full JID}" role="moderator"/> <status code="110"/> </x> </presence> Romeo receives: <message from="garden@conference.localhost" type="groupchat"> <subject/> </message> Romeo sends: <iq to="garden@conference.localhost" id="lx3" type="set"> <query xmlns="http://jabber.org/protocol/muc#owner"> <x type="submit" xmlns="jabber:x:data"/> </query> </iq> Romeo receives: <iq id="lx3" type="result" from="garden@conference.localhost"/> Juliet connects Romeo sends: <message to="garden@conference.localhost" type="groupchat" id="rm1"> <body>Where are thou my Juliet?</body> </message> Romeo receives: <message type="groupchat" from="garden@conference.localhost/romeo" id="rm1"> <body>Where are thou my Juliet?</body> </message> Juliet sends: <presence to="garden@conference.localhost/juliet"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Juliet receives: <presence from="garden@conference.localhost/romeo"> <x xmlns="vcard-temp:x:update"> <photo/> </x> <x xmlns="http://jabber.org/protocol/muc#user"> <item affiliation="owner" role="moderator"/> </x> </presence> Juliet receives: <presence from="garden@conference.localhost/juliet"> <x xmlns="vcard-temp:x:update"> <photo/> </x> <x xmlns="http://jabber.org/protocol/muc#user"> <item affiliation="none" jid="${Juliet's full JID}" role="participant"/> <status code="110"/> </x> </presence> Juliet receives: <message from="garden@conference.localhost/romeo" id="rm1" type="groupchat"> <body>Where are thou my Juliet?</body> <delay stamp="{scansion:any}" xmlns="urn:xmpp:delay" from="garden@conference.localhost"/> </message> Juliet receives: <message from="garden@conference.localhost" type="groupchat"> <subject/> </message> Romeo receives: <presence from="garden@conference.localhost/juliet"> <x xmlns="vcard-temp:x:update"> <photo/> </x> <x xmlns="http://jabber.org/protocol/muc#user"> <item affiliation="none" jid="${Juliet's full JID}" role="participant"/> </x> </presence> Juliet sends: <message to="garden@conference.localhost" type="groupchat" id="jm1"> <body>/me jumps out from behind a tree</body> </message> Romeo receives: <message type="groupchat" id="jm1" from="garden@conference.localhost/juliet"> <body>/me jumps out from behind a tree</body> </message> Juliet receives: <message type="groupchat" id="jm1" from="garden@conference.localhost/juliet"> <body>/me jumps out from behind a tree</body> </message> Juliet sends: <message to="garden@conference.localhost" type="groupchat" id="jm2"> <body>Here I am!</body> </message> Romeo receives: <message type="groupchat" id="jm2" from="garden@conference.localhost/juliet"> <body>Here I am!</body> </message> Juliet receives: <message type="groupchat" id="jm2" from="garden@conference.localhost/juliet"> <body>Here I am!</body> </message> Romeo sends: <message to="garden@conference.localhost" type="groupchat" id="rm2"> <body>What is this place?</body> </message> Romeo receives: <message type="groupchat" id="rm2" from="garden@conference.localhost/romeo"> <body>What is this place?</body> </message> Juliet receives: <message type="groupchat" id="rm2" from="garden@conference.localhost/romeo"> <body>What is this place?</body> </message> Juliet sends: <message to="garden@conference.localhost" type="groupchat" id="jm3"> <body>I think we're in a script!</body> </message> Romeo receives: <message type="groupchat" id="jm3" from="garden@conference.localhost/juliet"> <body>I think we're in a script!</body> </message> Juliet receives: <message type="groupchat" id="jm3" from="garden@conference.localhost/juliet"> <body>I think we're in a script!</body> </message> Romeo sends: <message to="garden@conference.localhost" type="groupchat" id="rm3"> <body>Oh no! Does that mean our love is not real?!</body> </message> Romeo receives: <message type="groupchat" id="rm3" from="garden@conference.localhost/romeo"> <body>Oh no! Does that mean our love is not real?!</body> </message> Juliet receives: <message type="groupchat" id="rm3" from="garden@conference.localhost/romeo"> <body>Oh no! Does that mean our love is not real?!</body> </message> Juliet sends: <message to="garden@conference.localhost" type="groupchat" id="jm4"> <body>I refuse to accept this! Let's burn this place to the ground!</body> </message> Romeo receives: <message type="groupchat" id="jm4" from="garden@conference.localhost/juliet"> <body>I refuse to accept this! Let's burn this place to the ground!</body> </message> Juliet receives: <message type="groupchat" id="jm4" from="garden@conference.localhost/juliet"> <body>I refuse to accept this! Let's burn this place to the ground!</body> </message> Romeo sends: <message to="garden@conference.localhost" type="groupchat" id="rm4"> <body>Yes!</body> </message> Romeo receives: <message type="groupchat" id="rm4" from="garden@conference.localhost/romeo"> <body>Yes!</body> </message> Juliet receives: <message type="groupchat" id="rm4" from="garden@conference.localhost/romeo"> <body>Yes!</body> </message> Romeo sends: <iq to="garden@conference.localhost" id="lx4" type="set"> <query xmlns="http://jabber.org/protocol/muc#owner"> <destroy> <reason>We refuse to live in this fantasy!</reason> </destroy> </query> </iq> Juliet receives: <presence from="garden@conference.localhost/juliet" type="unavailable"> <x xmlns="http://jabber.org/protocol/muc#user"> <destroy> <reason>We refuse to live in this fantasy!</reason> </destroy> <item affiliation="none" jid="${Juliet's full JID}" role="none"/> <status code="110"/> </x> </presence> Romeo receives: <presence from="garden@conference.localhost/romeo" type="unavailable"> <x xmlns="http://jabber.org/protocol/muc#user"> <destroy> <reason>We refuse to live in this fantasy!</reason> </destroy> <item affiliation="owner" jid="${Romeo's full JID}" role="none"/> <status code="110"/> </x> </presence> Romeo receives: <iq id="lx4" type="result" from="garden@conference.localhost"/> Juliet disconnects Romeo sends: <presence to="elsewhere@conference.localhost/romeo"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from="elsewhere@conference.localhost/romeo"> <x xmlns="vcard-temp:x:update"> <photo/> </x> <x xmlns="http://jabber.org/protocol/muc#user"> <status code="201"/> <item affiliation="owner" jid="${Romeo's full JID}" role="moderator"/> <status code="110"/> </x> </presence> Romeo receives: <message from="elsewhere@conference.localhost" type="groupchat"> <subject/> </message> Romeo sends: <iq to="elsewhere@conference.localhost" id="lx5" type="set"> <query xmlns="http://jabber.org/protocol/muc#owner"> <x type="submit" xmlns="jabber:x:data"/> </query> </iq> Romeo receives: <iq id="lx5" type="result" from="elsewhere@conference.localhost"/> Admin connects Admin sends: <iq id="destroy" type="set" to="conference.localhost"> <command xmlns="http://jabber.org/protocol/commands" node="http://prosody.im/protocol/muc#destroy"> <x xmlns="jabber:x:data"> <field var="rooms"> <value>elsewhere@conference.localhost</value> </field> </x> </command> </iq> Romeo receives: <presence from="elsewhere@conference.localhost/romeo" type="unavailable"> <x xmlns="http://jabber.org/protocol/muc#user"> <destroy/> <item affiliation="owner" jid="${Romeo's full JID}" role="none"/> <status code="110"/> </x> </presence> Romeo disconnects Admin receives: <iq id="destroy" type="result" from="conference.localhost"> <command xmlns="http://jabber.org/protocol/commands" node="http://prosody.im/protocol/muc#destroy" status="completed" sessionid="{scansion:any}"> <note type="info">The following rooms were destroyed: elsewhere@conference.localhost</note> </command> </iq> Admin disconnects # recording ended on 2019-08-31T13:45:32Z