Software /
code /
prosody
File
spec/scansion/muc_whois_anyone_member.scs @ 11748:88ba05494d17 0.11
makefile: fix prosody.version target
POSIX is quite explicit regarding the precedence of AND-OR lists [0]:
> The operators "&&" and "||" shall have equal precedence and shall be
> evaluated with left associativity. For example, both of the following
> commands write solely `bar` to standard output:
> false && echo foo || echo bar
> true || echo foo && echo bar
Given that, `prosody.version` target behaves as
((((((test -f prosody.release && cp ...) ||
test -f ...) &&
sed ...) ||
test -f ...) &&
hexdump ...) ||
echo unknown > $@)
In the case of release tarballs, `prosody.release` does exist, so the
first AND pair is executed. Given that it's successful, then the first
`test -f` in the OR pair is ignored, and instead the `sed` in the AND
pair is executed. `sed` success, as `.hg_archival.txt` exists, making
the second `test -f` in the OR pair ignored, and `hexdump` in the AND
pair is executed. Now, given that `.hg` doesn't exist, it fails, so the
last `echo` is run, overwriting `prosody.version` with `unknown`.
This can be worked around placing `()` around the AND pairs. Decided to use
conditionals instead, as I think they better communicate the intention
of the block.
[0]: https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_09_03
author | Lucas <lucas@sexy.is> |
---|---|
date | Sun, 15 Aug 2021 04:10:36 +0000 |
parent | 11712:d117b92fd8e4 |
line wrap: on
line source
# MUC: Allow members to fetch the affiliation lists in open non-anonymous rooms [Client] Romeo jid: 4e2pm7er@localhost password: password [Client] Juliet jid: qnjm5253@localhost password: password [Client] Random jid: iqizbcus@localhost password: password ----- Romeo connects Juliet connects Random connects # Romeo joins and creates the MUC Romeo sends: <presence to="mcgczevx@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc"/> </presence> Romeo receives: <presence from="mcgczevx@conference.localhost/Romeo"> <x xmlns="http://jabber.org/protocol/muc#user" scansion:strict="false"> <item affiliation="owner" jid="${Romeo's full JID}" role="moderator"/> <status code="110"/> <status code="201"/> </x> </presence> Romeo receives: <message from="mcgczevx@conference.localhost" type="groupchat"> <subject/> </message> # and configures it for private chat Romeo sends: <iq type="set" id="17fb8e7e-c75e-447c-b86f-3f1df8f507c4" to="mcgczevx@conference.localhost"> <query xmlns="http://jabber.org/protocol/muc#owner"> <x type="submit" xmlns="jabber:x:data"> <field var="FORM_TYPE"> <value>http://jabber.org/protocol/muc#roomconfig</value> </field> <field var="muc#roomconfig_membersonly"> <value>1</value> </field> <field var="muc#roomconfig_whois"> <value>anyone</value> </field> </x> </query> </iq> Romeo receives: <iq from="mcgczevx@conference.localhost" id="17fb8e7e-c75e-447c-b86f-3f1df8f507c4" type="result"/> Romeo receives: <message from="mcgczevx@conference.localhost" type="groupchat"> <x xmlns="http://jabber.org/protocol/muc#user" scansion:strict="false"> <status code="104"/> <status code="172"/> </x> </message> # Juliet is made a member Romeo sends: <iq type="set" id="32d81574-e1dc-4221-b36d-4c44debb7c19" to="mcgczevx@conference.localhost"> <query xmlns="http://jabber.org/protocol/muc#admin"> <item affiliation="member" jid="${Juliet's JID}"/> </query> </iq> # Juliet can read affiliations Juliet sends: <iq type="get" id="32d81574-e1dc-4221-b36d-4c44debb7c19" to="mcgczevx@conference.localhost"> <query xmlns="http://jabber.org/protocol/muc#admin"> <item affiliation="owner"/> </query> </iq> Juliet receives: <iq from="mcgczevx@conference.localhost" id="32d81574-e1dc-4221-b36d-4c44debb7c19" type="result"> <query xmlns="http://jabber.org/protocol/muc#admin"> <item affiliation="owner" jid="${Romeo's JID}"/> </query> </iq> Juliet sends: <iq type="get" id="05e3fe30-976f-4919-8221-ca1ac333eb9b" to="mcgczevx@conference.localhost"> <query xmlns="http://jabber.org/protocol/muc#admin"> <item affiliation="member"/> </query> </iq> Juliet receives: <iq from="mcgczevx@conference.localhost" id="05e3fe30-976f-4919-8221-ca1ac333eb9b" type="result"> <query xmlns="http://jabber.org/protocol/muc#admin"> <item affiliation="member" jid="${Juliet's JID}"/> </query> </iq> # Others can't read affiliations Random sends: <iq type="get" id="df1195e1-7ec8-4102-8561-3e3a1d942adf" to="mcgczevx@conference.localhost"> <query xmlns="http://jabber.org/protocol/muc#admin"> <item affiliation="owner"/> </query> </iq> Random receives: <iq from="mcgczevx@conference.localhost" id="df1195e1-7ec8-4102-8561-3e3a1d942adf" type="error"/> Juliet disconnects Romeo disconnects Random disconnects # recording ended on 2021-07-23T12:09:48Z