Software /
code /
prosody
File
CONTRIBUTING @ 12227:88958c0ecab3
mod_http_file_share: Use alternate syntax for filename in Content-Disposition
The Lua string.format %q doesn't behave correctly for all characters
that should be escaped in a quoted-string. And who knows what effects
higher Unicode might have here.
Applying percent-encoding of filenames seems like the safest way to deal
with filenames, as well as being easier than implementing the actual
quoted-string transform, which seems complicated and I'm not even sure
it covers every possible character.
Filenames can safely be assumed to be UTF-8 since they are passed in an
attribute in the query without any escaping.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sat, 29 Jan 2022 16:11:38 +0100 |
parent | 9946:ceaca48a7e6d |
line wrap: on
line source
Thanks for your interest in contributing to the project! There are many ways to contribute, such as helping improve the documentation, reporting bugs, spreading the word or testing the latest development version. You can find more information on how to contribute at <https://prosody.im/doc/contributing> See also the HACKERS and README files.