Software /
code /
prosody
File
spec/scansion/version.scs @ 11476:83e127eb91f9
util.datamapper: Deal with locally built stanzas missing xmlns
So the problem is that xmlns is not inherited when building a stanza,
and then :get_child(n, ns) with an explicit namespace does not find that
such child tags.
E.g.
local t = st.stanza("foo", { xmlns = "urn:example:bar" })
:text_tag("hello", "world");
assert(t:get_child("hello", "urn:example:bar"), "This fails");
Meanwhile, during parsing (util.xmppstream or util.xml) child tags do
get the parents xmlns when not overriding them.
Thus, in the above example, if the stanza is passed trough
`t = util.xml.parse(tostring(t))` then the assert succeeds.
This change makes it so that it leaves out the namespace argument to
:get_child when it is the same as the current/parent namespace, which
behaves the same for both built and parsed stanzas.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Tue, 23 Mar 2021 19:52:59 +0100 |
parent | 10729:dbce2b94a7eb |
line wrap: on
line source
# XEP-0092: Software Version / mod_version [Client] Romeo password: password jid: romeo@localhost/dfaZpuxV ----- Romeo connects Romeo sends: <iq id='lx2' to='localhost' type='get'> <query xmlns='jabber:iq:version'/> </iq> # Version string would vary so we can't do an exact match atm # Inclusion of <os/> is disabled in the config, it should be absent Romeo receives: <iq id='lx2' from='localhost' type='result'> <query xmlns='jabber:iq:version' scansion:strict='true'> <name>Prosody</name> <version scansion:strict='false'/> </query> </iq> Romeo disconnects