Software /
code /
prosody
File
spec/scansion/mam_prefs_prep.scs @ 11476:83e127eb91f9
util.datamapper: Deal with locally built stanzas missing xmlns
So the problem is that xmlns is not inherited when building a stanza,
and then :get_child(n, ns) with an explicit namespace does not find that
such child tags.
E.g.
local t = st.stanza("foo", { xmlns = "urn:example:bar" })
:text_tag("hello", "world");
assert(t:get_child("hello", "urn:example:bar"), "This fails");
Meanwhile, during parsing (util.xmppstream or util.xml) child tags do
get the parents xmlns when not overriding them.
Thus, in the above example, if the stanza is passed trough
`t = util.xml.parse(tostring(t))` then the assert succeeds.
This change makes it so that it leaves out the namespace argument to
:get_child when it is the same as the current/parent namespace, which
behaves the same for both built and parsed stanzas.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Tue, 23 Mar 2021 19:52:59 +0100 |
parent | 9729:4f6413ec08a8 |
child | 11727:f3aee8a825cc |
line wrap: on
line source
# mod_mam shold apply JIDprep in prefs [Client] Romeo jid: romeo@localhost password: password ----- Romeo connects Romeo sends: <iq id="lx2" type="set"> <prefs xmlns="urn:xmpp:mam:2" default="roster"> <always> <jid>JULIET@MONTAGUE.LIT</jid> </always> <never> <jid>MONTAGUE@MONTAGUE.LIT</jid> </never> </prefs> </iq> Romeo receives: <iq id="lx2" type="result"> <prefs xmlns="urn:xmpp:mam:2" default="roster"> <always> <jid>juliet@montague.lit</jid> </always> <never> <jid>montague@montague.lit</jid> </never> </prefs> </iq> Romeo disconnects