Software /
code /
prosody
File
spec/scansion/lastactivity.scs @ 11476:83e127eb91f9
util.datamapper: Deal with locally built stanzas missing xmlns
So the problem is that xmlns is not inherited when building a stanza,
and then :get_child(n, ns) with an explicit namespace does not find that
such child tags.
E.g.
local t = st.stanza("foo", { xmlns = "urn:example:bar" })
:text_tag("hello", "world");
assert(t:get_child("hello", "urn:example:bar"), "This fails");
Meanwhile, during parsing (util.xmppstream or util.xml) child tags do
get the parents xmlns when not overriding them.
Thus, in the above example, if the stanza is passed trough
`t = util.xml.parse(tostring(t))` then the assert succeeds.
This change makes it so that it leaves out the namespace argument to
:get_child when it is the same as the current/parent namespace, which
behaves the same for both built and parsed stanzas.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Tue, 23 Mar 2021 19:52:59 +0100 |
parent | 10732:f5d88ad24b30 |
child | 13405:c8f3cfe59e90 |
line wrap: on
line source
# XEP-0012: Last Activity / mod_lastactivity [Client] Romeo jid: romeo@localhost password: password ----- Romeo connects Romeo sends: <presence> <status>Hello</status> </presence> Romeo receives: <presence from="${Romeo's full JID}"> <status>Hello</status> </presence> Romeo sends: <presence type="unavailable"> <status>Goodbye</status> </presence> Romeo receives: <presence from="${Romeo's full JID}" type="unavailable"> <status>Goodbye</status> </presence> # mod_lastlog saves time + status message from the last unavailable presence Romeo sends: <iq id='a' type='get'> <query xmlns='jabber:iq:last'/> </iq> Romeo receives: <iq type='result' id='a'> <query xmlns='jabber:iq:last' seconds='0'>Goodbye</query> </iq> Romeo disconnects # recording ended on 2020-04-20T14:39:47Z