prosody
82c8e855c850
spec/scansion/issue1121.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/issue1121.scs @ 12189:82c8e855c850

mod_storage_xep0227: treat roster metadata pseudo-entry correctly The roster version is stored in a pseudo-item which has the key `false`. The if condition in the touched code attempts to guard against this, but it does not take into account that the jid prepping returns nil instead of false. By moving the jid prepping into the if, we can check for the metadata entry safely.
author Jonas Schäfer <jonas@wielicki.name>
date Sat, 15 Jan 2022 15:40:29 +0100
parent 12100:0b14b541fd27
line wrap: on
line source

# When removing roster contact, Prosody should send directed "unavailable" presence but sends global unavailable presence

[Client] Romeo
	jid: romeo@localhost
	password: password

[Client] Juliet
	jid: juliet@localhost
	password: password

-----

Romeo connects

Romeo sends
	<presence/>

Romeo receives
	<presence from="${Romeo's full JID}"/>

Juliet connects

Juliet sends
	<presence/>

Juliet receives
	<presence from="${Juliet's full JID}"/>

Romeo sends
	<presence to="juliet@localhost" type="subscribe"/>

Romeo receives
	<presence from="juliet@localhost" to="romeo@localhost"/>

Juliet receives
	<presence from="romeo@localhost" to="juliet@localhost" type="subscribe"/>

Juliet sends
	<presence to="romeo@localhost" type="subscribed"/>

Romeo receives
	<presence from="${Juliet's full JID}" to="romeo@localhost"/>

Juliet sends
	<presence to="romeo@localhost" type="subscribe"/>

Juliet receives
	<presence from="romeo@localhost" to="juliet@localhost"/>

Romeo receives
	<presence from="juliet@localhost" to="romeo@localhost" type="subscribe"/>

Romeo sends
	<presence to="juliet@localhost" type="subscribed"/>

Juliet receives
	<presence from="${Romeo's full JID}" to="juliet@localhost"/>

Romeo receives
	<presence from="${Juliet's full JID}" to="romeo@localhost"/>

Juliet sends
	<iq type="set" id="iq1">
		<query xmlns="jabber:iq:roster">
			<item jid="romeo@localhost" subscription="remove"/>
		</query>
	</iq>

Juliet receives
	<iq type="result" id="iq1"/>

Romeo receives
	<presence from="${Juliet's full JID}" to="romeo@localhost" type="unavailable"/>

Romeo disconnects