Software / code / prosody
File
util/gc.lua @ 13762:81856814d74f 13.0
util.argparse: Fix bug (regression?) in argument parsing with --foo=bar
After recent changes, '--foo bar' was working, but '--foo=bar' was not. The
test had a typo (?) (bar != baz) and because util.argparse is not strict by
default, the typo was not caught.
The typo caused the code to take a different path, and bypassed the buggy
handling of --foo=bar options.
I've preserved the existing test (typo and all!) because it's still an
interesting test, and ensures no unintended behaviour changes compared to the
old code.
However I've added a new variant of the test, with strict mode enabled and the
typo fixed. This test failed due to the bug, and this commit introduces a fix.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Tue, 11 Mar 2025 18:27:36 +0000 |
| parent | 12975:d10957394a3c |
line wrap: on
line source
local set = require "prosody.util.set"; local known_options = { incremental = set.new { "mode", "threshold", "speed", "step_size" }; generational = set.new { "mode", "minor_threshold", "major_threshold" }; }; if _VERSION ~= "Lua 5.4" then known_options.generational = nil; known_options.incremental:remove("step_size"); end local function configure(user, defaults) local mode = user.mode or defaults.mode or "incremental"; if not known_options[mode] then return nil, "GC mode not supported on ".._VERSION..": "..mode; end for k, v in pairs(user) do if not known_options[mode]:contains(k) then return nil, "Unknown GC parameter: "..k; elseif k ~= "mode" and type(v) ~= "number" then return nil, "parameter '"..k.."' should be a number"; end end if mode == "incremental" then if _VERSION == "Lua 5.4" then collectgarbage(mode, user.threshold or defaults.threshold, user.speed or defaults.speed, user.step_size or defaults.step_size ); else collectgarbage("setpause", user.threshold or defaults.threshold); collectgarbage("setstepmul", user.speed or defaults.speed); end elseif mode == "generational" then collectgarbage(mode, user.minor_threshold or defaults.minor_threshold, user.major_threshold or defaults.major_threshold ); end return true; end return { configure = configure; };