File

plugins/muc/persistent.lib.lua @ 13762:81856814d74f 13.0

util.argparse: Fix bug (regression?) in argument parsing with --foo=bar After recent changes, '--foo bar' was working, but '--foo=bar' was not. The test had a typo (?) (bar != baz) and because util.argparse is not strict by default, the typo was not caught. The typo caused the code to take a different path, and bypassed the buggy handling of --foo=bar options. I've preserved the existing test (typo and all!) because it's still an interesting test, and ensures no unintended behaviour changes compared to the old code. However I've added a new variant of the test, with strict mode enabled and the typo fixed. This test failed due to the bug, and this commit introduces a fix.
author Matthew Wild <mwild1@gmail.com>
date Tue, 11 Mar 2025 18:27:36 +0000
parent 13170:082c7d856e61
line wrap: on
line source

-- Prosody IM
-- Copyright (C) 2008-2010 Matthew Wild
-- Copyright (C) 2008-2010 Waqas Hussain
-- Copyright (C) 2014 Daurnimator
--
-- This project is MIT/X11 licensed. Please see the
-- COPYING file in the source package for more information.
--

local restrict_persistent = not module:get_option_boolean("muc_room_allow_persistent", true);
module:default_permission(
	restrict_persistent and "prosody:admin" or "prosody:registered",
	":create-persistent-room"
);

local function get_persistent(room)
	return room._data.persistent;
end

local function set_persistent(room, persistent)
	persistent = persistent and true or nil;
	if get_persistent(room) == persistent then return false; end
	room._data.persistent = persistent;
	return true;
end

module:hook("muc-config-form", function(event)
	if not module:may(":create-persistent-room", event.actor) then
		-- Hide config option if this user is not allowed to create persistent rooms
		return;
	end
	table.insert(event.form, {
		name = "muc#roomconfig_persistentroom";
		type = "boolean";
		label = "Persistent (room should remain even when it is empty)";
		desc = "Rooms are automatically deleted when they are empty, unless this option is enabled";
		value = get_persistent(event.room);
	});
end, 100-5);

module:hook("muc-config-submitted/muc#roomconfig_persistentroom", function(event)
	if not module:may(":create-persistent-room", event.actor) then
		return; -- Not allowed
	end
	if set_persistent(event.room, event.value) then
		event.status_codes["104"] = true;
	end
end);

module:hook("muc-disco#info", function(event)
	event.reply:tag("feature", {var = get_persistent(event.room) and "muc_persistent" or "muc_temporary"}):up();
end);

module:hook("muc-room-destroyed", function(event)
	set_persistent(event.room, false);
end, -100);

return {
	get = get_persistent;
	set = set_persistent;
};