Software /
code /
prosody
File
spec/scansion/presence_preapproval.scs @ 12525:8087f5357f53 0.12
mod_smacks: Fix bounce of stanzas directed to full JID on unclean disconnect
Fixes #1758
Introduced in 1ea01660c79a
In e62025f949f9 to and from was inverted since it changed from acting on
a reply to acting on the original stanza (or a clone thereof)
Unsure of the purpose of this check, you don't usually send stanzas to
your own full JID. Perhaps guarding against routing loops?
The check was present in the original commit of mod_smacks,
prosody-modules rev 9a7671720dec
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Fri, 27 May 2022 12:05:47 +0200 |
parent | 10515:35bf3b80480f |
line wrap: on
line source
# server supports contact subscription pre-approval (RFC 6121 3.4) [Client] Alice jid: preappove-a@localhost password: password [Client] Bob jid: preapprove-b@localhost password: password --------- Alice connects Alice sends: <presence/> Alice receives: <presence/> Alice sends: <presence to="${Bob's JID}" type="subscribed"/> Bob connects Bob sends: <iq type="get" id="roster1"> <query xmlns="jabber:iq:roster"/> </iq> Bob receives: <iq type="result" id="roster1"> <query xmlns="jabber:iq:roster" ver="{scansion:any}"> </query> </iq> Bob sends: <presence/> Bob receives: <presence from="${Bob's full JID}"/> Bob sends: <presence to="${Alice's JID}" type="subscribe" /> Bob receives: <iq type='set' id='{scansion:any}'> <query ver='1' xmlns='jabber:iq:roster'> <item jid="${Alice's JID}" subscription='none' ask='subscribe' /> </query> </iq> Bob receives: <presence from="${Alice's JID}" type="subscribed" /> Bob disconnects Alice sends: <iq type="get" id="roster1"> <query xmlns="jabber:iq:roster"/> </iq> Alice receives: <iq type="result" id="roster1"> <query xmlns="jabber:iq:roster" ver="{scansion:any}"> <item jid="${Bob's JID}" subscription="from" /> </query> </iq> Alice disconnects Bob disconnects