Software / code / prosody
File
util/jsonpointer.lua @ 13765:7c57fb2ffbb0 13.0
mod_websocket: Merge session close handling changes from mod_c2s (bug fixes)
This should bring some fixes and general robustness that mod_websocket had
missed out on. The duplicated code here is not at all ideal. To prevent this
happening again, we should figure out how to have the common logic in a single
place, while still being able to do the websocket-specific parts that we need.
The main known bug that this fixes is that it's possible for a session to get
into a non-destroyable state. For example, if we try to session:close() a
hibernating session, then session.conn is nil and the function will simply
return without doing anything. In the mod_c2s code we already handle this, and
just destroy the session. But if a hibernating websocket session is never
resumed or becomes non-resumable, it will become immortal!
By merging the fix from mod_c2s, the session should now be correctly
destroyed.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Tue, 11 Mar 2025 18:44:40 +0000 |
| parent | 12781:22066b02887f |
line wrap: on
line source
local m_type = math.type; local function unescape_token(escaped_token) local unescaped = escaped_token:gsub("~1", "/"):gsub("~0", "~") return unescaped end local function resolve_json_pointer(ref, path) local ptr_len = #path + 1 for part, pos in path:gmatch("/([^/]*)()") do local token = unescape_token(part) if not (type(ref) == "table") then return nil end local idx = next(ref) local new_ref if type(idx) == "string" then new_ref = ref[token] elseif m_type(idx) == "integer" then local i = tonumber(token) if token == "-" then i = #ref + 1 end new_ref = ref[i + 1] else return nil, "invalid-table" end if pos == ptr_len then return new_ref elseif type(new_ref) == "table" then ref = new_ref elseif not (type(ref) == "table") then return nil, "invalid-path" end end return ref end return { resolve = resolve_json_pointer }