Software / code / prosody
File
util-src/makefile @ 13765:7c57fb2ffbb0 13.0
mod_websocket: Merge session close handling changes from mod_c2s (bug fixes)
This should bring some fixes and general robustness that mod_websocket had
missed out on. The duplicated code here is not at all ideal. To prevent this
happening again, we should figure out how to have the common logic in a single
place, while still being able to do the websocket-specific parts that we need.
The main known bug that this fixes is that it's possible for a session to get
into a non-destroyable state. For example, if we try to session:close() a
hibernating session, then session.conn is nil and the function will simply
return without doing anything. In the mod_c2s code we already handle this, and
just destroy the session. But if a hibernating websocket session is never
resumed or becomes non-resumable, it will become immortal!
By merging the fix from mod_c2s, the session should now be correctly
destroyed.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Tue, 11 Mar 2025 18:44:40 +0000 |
| parent | 12364:261ce358e436 |
line wrap: on
line source
include ../config.unix CFLAGS+=-I$(LUA_INCDIR) INSTALL_DATA=install -m644 TARGET?=../util/ ALL=encodings.so hashes.so net.so pposix.so signal.so table.so \ ringbuffer.so time.so poll.so compat.so strbitop.so \ struct.so .ifdef $(RANDOM) ALL+=crand.so .endif .PHONY: all install clean .SUFFIXES: .c .o .so all: $(ALL) install: $(ALL) $(INSTALL_DATA) $(ALL) $(TARGET) clean: rm -f $(ALL) $(patsubst %.so,%.o,$(ALL)) encodings.o: encodings.c $(CC) $(CFLAGS) $(IDNA_FLAGS) -c -o $@ $< encodings.so: encodings.o $(LD) $(LDFLAGS) -o $@ $< $(LDLIBS) $(IDNA_LIBS) hashes.so: hashes.o $(LD) $(LDFLAGS) -o $@ $< $(LDLIBS) $(OPENSSL_LIBS) crand.o: crand.c $(CC) $(CFLAGS) -DWITH_$(RANDOM) -c -o $@ $< crand.so: crand.o $(LD) $(LDFLAGS) -o $@ $< $(LDLIBS) $(RANDOM_LIBS) %.so: %.o $(LD) $(LDFLAGS) -o $@ $< $(LDLIBS) .c.o: $(CC) $(CFLAGS) -c -o $@ $< .o.so: $(LD) $(LDFLAGS) -o $@ $< $(LDLIBS)