Software /
code /
prosody
File
spec/scansion/extdisco.scs @ 12729:73a45ba6e3f1
muc: Re-allow non-admins to configure persistence (thanks Meaz)
Non-admins don't have a role on MUC services by default. Not even
prosody:user. This meant they had no :create-persistent-room permission, even
if muc_room_allow_persistent was true (the default).
Now we only check the role permissions if persistent room creation is
restricted, otherwise we skip any permission checks, just like previous
versions.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 28 Sep 2022 17:47:00 +0100 |
parent | 11753:c4599a7c534c |
child | 13405:c8f3cfe59e90 |
line wrap: on
line source
# XEP-0215: External Service Discovery [Client] Romeo password: password jid: user@localhost/mFquWxSr ----- Romeo connects Romeo sends: <iq type='get' xml:lang='sv' id='lx2' to='localhost'> <services xmlns='urn:xmpp:extdisco:2'/> </iq> Romeo receives: <iq type='result' id='lx2' from='localhost'> <services xmlns='urn:xmpp:extdisco:2'> <service host='default.example' transport='udp' port='9876' type='stun'/> <service port='9876' type='turn' restricted='1' password='yHYYBDN7M3mdlug0LTdJbW0GvvQ=' transport='udp' host='default.example' username='1219525744'/> <service port='9876' type='turn' restricted='1' password='1Uc6QfrDhIlbK97rGCUQ/cUICxs=' transport='udp' host='default.example' username='1219525744'/> <service port='2121' type='ftp' restricted='1' password='password' transport='tcp' host='default.example' username='john'/> <service port='21' type='ftp' restricted='1' password='password' transport='tcp' host='ftp.example.com' username='john'/> </services> </iq> Romeo sends: <iq type='get' xml:lang='sv' id='lx3' to='localhost'> <services xmlns='urn:xmpp:extdisco:2' type='ftp'/> </iq> Romeo receives: <iq type='result' id='lx3' from='localhost'> <services xmlns='urn:xmpp:extdisco:2'> <service port='2121' type='ftp' restricted='1' password='password' transport='tcp' host='default.example' username='john'/> <service port='21' type='ftp' restricted='1' password='password' transport='tcp' host='ftp.example.com' username='john'/> </services> </iq> Romeo sends: <iq type='get' xml:lang='sv' id='lx4' to='localhost'> <credentials xmlns='urn:xmpp:extdisco:2'> <service host='default.example' type='turn'/> </credentials> </iq> Romeo receives: <iq type='result' id='lx4' from='localhost'> <credentials xmlns='urn:xmpp:extdisco:2'> <service port='9876' type='turn' restricted='1' password='yHYYBDN7M3mdlug0LTdJbW0GvvQ=' transport='udp' host='default.example' username='1219525744'/> <service port='9876' type='turn' restricted='1' password='1Uc6QfrDhIlbK97rGCUQ/cUICxs=' transport='udp' host='default.example' username='1219525744'/> </credentials> </iq> Romeo sends: <iq type='get' xml:lang='sv' id='lx5' to='localhost'> <credentials xmlns='urn:xmpp:extdisco:2'> <service host='default.example' /> </credentials> </iq> Romeo receives: <iq type='error' id='lx5' from='localhost'> <error type='modify'> <bad-request xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/> </error> </iq> Romeo disconnects # recording ended on 2020-07-18T16:47:57Z