prosody
735b8f4a6d7e
spec/scansion/muc_subject_issue_667.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/muc_subject_issue_667.scs @ 11661:735b8f4a6d7e

net.http: Send entire HTTP request header as one write When opportunistic writes are enabled this reduces the number of syscalls and TCP packets sent on the wire. Experiments with TCP Fast Open made this even more obvious. That table trick probably wasn't as efficient. Lua generates bytecode for a table with zero array slots and space for two entries in the hash part, plus code to set [2] and [4]. I didn't verify but I suspect it would have had to resize the table when setting [1] and [3], although probably only once. Concatenating the strings directly in Lua is easier to read and involves no extra table or function call.
author Kim Alvefur <zash@zash.se>
date Thu, 08 Jul 2021 18:21:59 +0200
parent 9708:6507df6d2c55
child 13414:d54364746a7c
line wrap: on
line source

# #667 MUC message with subject and body SHALL NOT be interpreted as a subject change

[Client] Romeo
	password: password
	jid: romeo@localhost

-----

Romeo connects

# and creates a room
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<status code="201"/>
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

# the default (empty) subject
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost">
		<subject/>
	</message>

# this should be treated as a normal message
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

# Resync
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

# Presences
Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

# the still empty subject
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost">
		<subject/>
	</message>

# this is a subject change
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<subject>Something to talk about</subject>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Something to talk about</subject>
	</message>

# a message without <subject>
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

# Resync
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

# Presences
Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

# History
# These have delay tags but we ignore those for now
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

# Finally, the topic
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Something to talk about</subject>
	</message>

Romeo disconnects