Software /
code /
prosody
File
util/error.lua @ 10851:6cf16abd0976
net.server_select: Ensure onconnect is always called before onincoming
This changes the code to call onconnect when the first data is sucessfully
read or written, instead of simply when the socket first becomes writable.
A writable socket can mean a connection error, and if the client already
sent some data it may get passed to onincoming before processing writable
sockets. This fixes the issue.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Mon, 01 Jun 2020 13:38:47 +0100 |
parent | 10501:e8186aba1583 |
child | 11050:51be24b16e8a |
line wrap: on
line source
local error_mt = { __name = "error" }; function error_mt:__tostring() return ("error<%s:%s:%s>"):format(self.type, self.condition, self.text or ""); end local function is_err(e) return getmetatable(e) == error_mt; end -- Do we want any more well-known fields? -- Or could we just copy all fields from `e`? -- Sometimes you want variable details in the `text`, how to handle that? -- Translations? -- Should the `type` be restricted to the stanza error types or free-form? -- What to set `type` to for stream errors or SASL errors? Those don't have a 'type' attr. local function new(e, context, registry) local template = (registry and registry[e]) or e or {}; return setmetatable({ type = template.type or "cancel"; condition = template.condition or "undefined-condition"; text = template.text; code = template.code; context = context or template.context or { _error_id = e }; }, error_mt); end local function coerce(ok, err, ...) if ok or is_err(err) then return ok, err, ...; end local new_err = setmetatable({ native = err; type = "cancel"; condition = "undefined-condition"; }, error_mt); return ok, new_err, ...; end local function from_stanza(stanza, context) local error_type, condition, text = stanza:get_error(); return setmetatable({ type = error_type or "cancel"; condition = condition or "undefined-condition"; text = text; context = context or { stanza = stanza }; }, error_mt); end return { new = new; coerce = coerce; is_err = is_err; from_stanza = from_stanza; }