File

spec/util_multitable_spec.lua @ 11592:64cfa396bb84

net.server_epoll: Fix reporting of socket connect timeout If the underlying TCP connection times out before the write timeout kicks in, end up here with err="timeout", which the following code treats as a minor issue. Then, due to epoll apparently returning the EPOLLOUT (writable) event too, we go on and try to write to the socket (commonly stream headers). This fails because the socket is closed, which becomes the error returned up the stack to the rest of Prosody. This also trips the 'onconnect' signal, which has effects on various things, such as the net.connect state machine. Probably undesirable effects. With this, we instead return "connection timeout", like server_event, and destroy the connection handle properly. And then nothing else happens because the connection has been destroyed.
author Kim Alvefur <zash@zash.se>
date Mon, 07 Jun 2021 17:37:14 +0200
parent 8236:4878e4159e12
line wrap: on
line source


local multitable = require "util.multitable";

describe("util.multitable", function()
	describe("#new()", function()
		it("should create a multitable", function()
			local mt = multitable.new();
			assert.is_table(mt, "Multitable is a table");
			assert.is_function(mt.add, "Multitable has method add");
			assert.is_function(mt.get, "Multitable has method get");
			assert.is_function(mt.remove, "Multitable has method remove");
		end);
	end);

	describe("#get()", function()
		it("should allow getting correctly", function()
			local function has_items(list, ...)
				local should_have = {};
				if select('#', ...) > 0 then
					assert.is_table(list, "has_items: list is table", 3);
				else
					assert.is.falsy(list and #list > 0, "No items, and no list");
					return true, "has-all";
				end
				for n=1,select('#', ...) do should_have[select(n, ...)] = true; end
				for _, item in ipairs(list) do
					if not should_have[item] then return false, "too-many"; end
					should_have[item] = nil;
				end
				if next(should_have) then
					return false, "not-enough";
				end
				return true, "has-all";
			end
			local function assert_has_all(message, list, ...)
				return assert.are.equal(select(2, has_items(list, ...)), "has-all", message or "List has all expected items, and no more", 2);
			end

			local mt = multitable.new();

			local trigger1, trigger2, trigger3 = {}, {}, {};
			local item1, item2, item3 = {}, {}, {};

			assert_has_all("Has no items with trigger1", mt:get(trigger1));


			mt:add(1, 2, 3, item1);

			assert_has_all("Has item1 for 1, 2, 3", mt:get(1, 2, 3), item1);
		end);
	end);

	-- Doesn't support nil
	--[[	mt:add(nil, item1);
		mt:add(nil, item2);
		mt:add(nil, item3);

		assert_has_all("Has all items with (nil)", mt:get(nil), item1, item2, item3);
	]]
end);