Software /
code /
prosody
File
spec/scansion/vcard_temp.scs @ 11592:64cfa396bb84
net.server_epoll: Fix reporting of socket connect timeout
If the underlying TCP connection times out before the write timeout
kicks in, end up here with err="timeout", which the following code
treats as a minor issue.
Then, due to epoll apparently returning the EPOLLOUT (writable) event
too, we go on and try to write to the socket (commonly stream headers).
This fails because the socket is closed, which becomes the error
returned up the stack to the rest of Prosody.
This also trips the 'onconnect' signal, which has effects on various
things, such as the net.connect state machine. Probably undesirable
effects.
With this, we instead return "connection timeout", like server_event,
and destroy the connection handle properly. And then nothing else
happens because the connection has been destroyed.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Mon, 07 Jun 2021 17:37:14 +0200 |
parent | 9524:1f6f3b941eb1 |
child | 12967:53b0730093d8 |
line wrap: on
line source
# XEP-0054 vCard-temp writable and readable by anyone # mod_scansion_record on host 'localhost' recording started 2018-10-20T15:00:12Z [Client] Romeo jid: romeo@localhost password: password [Client] Juliet jid: juliet@localhost password: password ----- Romeo connects # Romeo sets his vCard # FN and N are required by the schema and mod_vcard_legacy will always inject them Romeo sends: <iq id="lx3" type="set"> <vCard xmlns="vcard-temp"> <FN>Romeo Montague</FN> <N> <FAMILY>Montague</FAMILY> <GIVEN>Romeo</GIVEN> <MIDDLE/> <PREFIX/> <SUFFIX/> </N> </vCard> </iq> Romeo receives: <iq type="result" id="lx3" to="${Romeo's full JID}"/> Romeo sends: <iq id="lx4" type="get"> <vCard xmlns="vcard-temp"/> </iq> Romeo receives: <iq type="result" id="lx4" to="${Romeo's full JID}"> <vCard xmlns="vcard-temp"> <FN>Romeo Montague</FN> <N> <FAMILY>Montague</FAMILY> <GIVEN>Romeo</GIVEN> <MIDDLE/> <PREFIX/> <SUFFIX/> </N> </vCard> </iq> Romeo disconnects Juliet connects Juliet sends: <iq type="get" id="lx3" to="romeo@localhost"> <vCard xmlns="vcard-temp"/> </iq> # Juliet can see Romeo's vCard since it's public Juliet receives: <iq type="result" from="romeo@localhost" id="lx3" to="${Juliet's full JID}"> <vCard xmlns="vcard-temp"> <FN>Romeo Montague</FN> <N> <FAMILY>Montague</FAMILY> <GIVEN>Romeo</GIVEN> <MIDDLE/> <PREFIX/> <SUFFIX/> </N> </vCard> </iq> Juliet disconnects # recording ended on 2018-10-20T15:02:14Z