File

Statistics: Rewrite statistics backends to use OpenMetrics The metric subsystem of Prosody has had some shortcomings from the perspective of the current state-of-the-art in metric observability. The OpenMetrics standard [0] is a formalization of the data model (and serialization format) of the well-known and widely-used Prometheus [1] software stack. The previous stats subsystem of Prosody did not map well to that format (see e.g. [2] and [3]); the key reason is that it was trying to do too much math on its own ([2]) while lacking first-class support for "families" of metrics ([3]) and structured metric metadata (despite the `extra` argument to metrics, there was no standard way of representing common things like "tags" or "labels"). Even though OpenMetrics has grown from the Prometheus world of monitoring, it maps well to other popular monitoring stacks such as: - InfluxDB (labels can be mapped to tags and fields as necessary) - Carbon/Graphite (labels can be attached to the metric name with dot-separation) - StatsD (see graphite when assuming that graphite is used as backend, which is the default) The util.statsd module has been ported to use the OpenMetrics model as a proof of concept. An implementation which exposes the util.statistics backend data as Prometheus metrics is ready for publishing in prosody-modules (most likely as mod_openmetrics_prometheus to avoid breaking existing 0.11 deployments). At the same time, the previous measure()-based API had one major advantage: It is really simple and easy to use without requiring lots of knowledge about OpenMetrics or similar concepts. For that reason as well as compatibility with existing code, it is preserved and may even be extended in the future. However, code relying on the `stats-updated` event as well as `get_stats` from `statsmanager` will break because the data model has changed completely; in case of `stats-updated`, the code will simply not run (as the event was renamed in order to avoid conflicts); the `get_stats` function has been removed completely (so it will cause a traceback when it is attempted to be used). Note that the measure_*_event methods have been removed from the module API. I was unable to find any uses or documentation and thus deemed they should not be ported. Re-implementation is possible when necessary. [0]: https://openmetrics.io/ [1]: https://prometheus.io/ [2]: #959 [3]: #960

local multitable = require "util.multitable";

describe("util.multitable", function()
	describe("#new()", function()
		it("should create a multitable", function()
			local mt = multitable.new();
			assert.is_table(mt, "Multitable is a table");
			assert.is_function(mt.add, "Multitable has method add");
			assert.is_function(mt.get, "Multitable has method get");
			assert.is_function(mt.remove, "Multitable has method remove");
		end);
	end);

	describe("#get()", function()
		it("should allow getting correctly", function()
			local function has_items(list, ...)
				local should_have = {};
				if select('#', ...) > 0 then
					assert.is_table(list, "has_items: list is table", 3);
				else
					assert.is.falsy(list and #list > 0, "No items, and no list");
					return true, "has-all";
				end
				for n=1,select('#', ...) do should_have[select(n, ...)] = true; end
				for _, item in ipairs(list) do
					if not should_have[item] then return false, "too-many"; end
					should_have[item] = nil;
				end
				if next(should_have) then
					return false, "not-enough";
				end
				return true, "has-all";
			end
			local function assert_has_all(message, list, ...)
				return assert.are.equal(select(2, has_items(list, ...)), "has-all", message or "List has all expected items, and no more", 2);
			end

			local mt = multitable.new();

			local trigger1, trigger2, trigger3 = {}, {}, {};
			local item1, item2, item3 = {}, {}, {};

			assert_has_all("Has no items with trigger1", mt:get(trigger1));


			mt:add(1, 2, 3, item1);

			assert_has_all("Has item1 for 1, 2, 3", mt:get(1, 2, 3), item1);
		end);
	end);

	-- Doesn't support nil
	--[[	mt:add(nil, item1);
		mt:add(nil, item2);
		mt:add(nil, item3);

		assert_has_all("Has all items with (nil)", mt:get(nil), item1, item2, item3);
	]]
end);