Software /
code /
prosody
File
spec/scansion/presence_preapproval.scs @ 11972:520ce76440ad
net.server_epoll: Prevent loop attempting to send last data after close
If the connection is closed by the peer, any buffered data is given a
last chance to be sent (see f27b9319e0da). If the connection is Really
closed, no attempt to write will occur, instead epoll will raise the
error flag and :onreadable() will be invoked again, where it will try to
:close() again for the same reason, thus looping until the connection
somehow gets destroyed.
By clearing the _connected flag, the second time it passes :onreadable()
it should go directly to :destroy(), breaking the loop.
Thanks Link Mauve for reporting
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Tue, 30 Nov 2021 18:19:40 +0100 |
parent | 10515:35bf3b80480f |
line wrap: on
line source
# server supports contact subscription pre-approval (RFC 6121 3.4) [Client] Alice jid: preappove-a@localhost password: password [Client] Bob jid: preapprove-b@localhost password: password --------- Alice connects Alice sends: <presence/> Alice receives: <presence/> Alice sends: <presence to="${Bob's JID}" type="subscribed"/> Bob connects Bob sends: <iq type="get" id="roster1"> <query xmlns="jabber:iq:roster"/> </iq> Bob receives: <iq type="result" id="roster1"> <query xmlns="jabber:iq:roster" ver="{scansion:any}"> </query> </iq> Bob sends: <presence/> Bob receives: <presence from="${Bob's full JID}"/> Bob sends: <presence to="${Alice's JID}" type="subscribe" /> Bob receives: <iq type='set' id='{scansion:any}'> <query ver='1' xmlns='jabber:iq:roster'> <item jid="${Alice's JID}" subscription='none' ask='subscribe' /> </query> </iq> Bob receives: <presence from="${Alice's JID}" type="subscribed" /> Bob disconnects Alice sends: <iq type="get" id="roster1"> <query xmlns="jabber:iq:roster"/> </iq> Alice receives: <iq type="result" id="roster1"> <query xmlns="jabber:iq:roster" ver="{scansion:any}"> <item jid="${Bob's JID}" subscription="from" /> </query> </iq> Alice disconnects Bob disconnects