prosody
479e96e554c8
spec/scansion/muc_subject_issue_667.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/muc_subject_issue_667.scs @ 10486:479e96e554c8

net.server_epoll: Add debug logging for delayed reading In :onreadable, if there is still buffered incoming data after reading from the socket (as indicated by the :dirty method, usually because LuaSocket has an 8k buffer that's full but it read a smaller amount), another attempt to read is scheduled via this :pausefor method. This is also called from some other places where it would be pointless to read because there shouldn't be any data. In the delayed read case, this should report that the socket is "dirty". If it reports that the socket is "clean" then the question is where the buffer contents went? If this doesn't get logged after the scheduled time (0.000001s by default) then this would suggests a problem with timer or scheduling.
author Kim Alvefur <zash@zash.se>
date Sat, 07 Dec 2019 19:05:10 +0100
parent 9708:6507df6d2c55
line wrap: on
line source

# #667 MUC message with subject and body SHALL NOT be interpreted as a subject change

[Client] Romeo
	password: password
	jid: romeo@localhost

-----

Romeo connects

# and creates a room
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<status code="201"/>
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

# the default (empty) subject
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost">
		<subject/>
	</message>

# this should be treated as a normal message
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

# Resync
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

# Presences
Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

# the still empty subject
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost">
		<subject/>
	</message>

# this is a subject change
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<subject>Something to talk about</subject>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Something to talk about</subject>
	</message>

# a message without <subject>
Romeo sends:
	<message to="issue667@conference.localhost" type="groupchat">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

# Resync
Romeo sends:
	<presence to="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

# Presences
Romeo receives:
	<presence from="issue667@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc#user">
			<item affiliation="owner" role="moderator" jid="${Romeo's full JID}"/>
			<status code="110"/>
		</x>
	</presence>

# History
# These have delay tags but we ignore those for now
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Greetings</subject>
		<body>Hello everyone</body>
	</message>

Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<body>Lorem ipsum dolor sit amet</body>
	</message>

# Finally, the topic
Romeo receives:
	<message type="groupchat" from="issue667@conference.localhost/Romeo">
		<subject>Something to talk about</subject>
	</message>

Romeo disconnects