prosody
353836684009
spec/scansion/keep_full_sub_req.scs
Software / code / prosody
File
spec/scansion/keep_full_sub_req.scs @ 12468:353836684009
net.connect: Fix accumulation of connection attempt references
Connection attempts that failed the Happy Eyeballs race were not
unreferenced and would accumulate.
Tested by inspecting the 'pending_connections_map' after establishing
s2s with a s2s target where the IPv6 port has a -j DROP rule causing it
to time out and the IPv4 attempt wins the race.
Expected is that the losing connection stays around until net.server
timeouts kick in where it should be removed. The map table should tend
towards being empty during idle times.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Wed, 20 Apr 2022 22:41:54 +0200 |
| parent | 10515:35bf3b80480f |
line wrap: on
line source
# server MUST keep a record of the complete presence stanza comprising the subscription request (#689) [Client] Alice jid: pars-a@localhost password: password [Client] Bob jid: pars-b@localhost password: password [Client] Bob's phone jid: pars-b@localhost/phone password: password --------- Alice connects Alice sends: <presence to="${Bob's JID}" type="subscribe"> <preauth xmlns="urn:xmpp:pars:0" token="1tMFqYDdKhfe2pwp" /> </presence> Alice disconnects Bob connects Bob sends: <presence/> Bob receives: <presence from="${Bob's full JID}"/> Bob receives: <presence from="${Alice's JID}" type="subscribe"> <preauth xmlns="urn:xmpp:pars:0" token="1tMFqYDdKhfe2pwp" /> </presence> Bob disconnects # Works if they reconnect too Bob's phone connects Bob's phone sends: <presence/> Bob's phone receives: <presence from="${Bob's phone's full JID}"/> Bob's phone receives: <presence from="${Alice's JID}" type="subscribe"> <preauth xmlns="urn:xmpp:pars:0" token="1tMFqYDdKhfe2pwp" /> </presence> Bob's phone disconnects
