prosody
1a915c2e0fa4
spec/scansion/issue1121.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/issue1121.scs @ 13546:1a915c2e0fa4 0.12

mod_bookmarks: Suppress error publishing empty legacy bookmarks w/ no PEP node It appears that when: 1) The user has no bookmarks 2 node in PEP 2) The client publishes an empty bookmark set to a legacy bookmarks location 3) mod_bookmarks will attempt to purge items from the non-existent node and log an error about the failure (item-not-found). This new code will suppress an item-not-found error from the purge operation in the empty-bookmarks case, and adds a log message for any other error (this is helpful because the existing log message confusingly says it was an error *publishing* to the node, which isn't always accurate).
author Matthew Wild <mwild1@gmail.com>
date Fri, 08 Nov 2024 10:24:42 +0000
parent 12100:0b14b541fd27
line wrap: on
line source

# When removing roster contact, Prosody should send directed "unavailable" presence but sends global unavailable presence

[Client] Romeo
	jid: romeo@localhost
	password: password

[Client] Juliet
	jid: juliet@localhost
	password: password

-----

Romeo connects

Romeo sends
	<presence/>

Romeo receives
	<presence from="${Romeo's full JID}"/>

Juliet connects

Juliet sends
	<presence/>

Juliet receives
	<presence from="${Juliet's full JID}"/>

Romeo sends
	<presence to="juliet@localhost" type="subscribe"/>

Romeo receives
	<presence from="juliet@localhost" to="romeo@localhost"/>

Juliet receives
	<presence from="romeo@localhost" to="juliet@localhost" type="subscribe"/>

Juliet sends
	<presence to="romeo@localhost" type="subscribed"/>

Romeo receives
	<presence from="${Juliet's full JID}" to="romeo@localhost"/>

Juliet sends
	<presence to="romeo@localhost" type="subscribe"/>

Juliet receives
	<presence from="romeo@localhost" to="juliet@localhost"/>

Romeo receives
	<presence from="juliet@localhost" to="romeo@localhost" type="subscribe"/>

Romeo sends
	<presence to="juliet@localhost" type="subscribed"/>

Juliet receives
	<presence from="${Romeo's full JID}" to="juliet@localhost"/>

Romeo receives
	<presence from="${Juliet's full JID}" to="romeo@localhost"/>

Juliet sends
	<iq type="set" id="iq1">
		<query xmlns="jabber:iq:roster">
			<item jid="romeo@localhost" subscription="remove"/>
		</query>
	</iq>

Juliet receives
	<iq type="result" id="iq1"/>

Romeo receives
	<presence from="${Juliet's full JID}" to="romeo@localhost" type="unavailable"/>

Romeo disconnects