File

mod_bookmarks: Suppress error publishing empty legacy bookmarks w/ no PEP node It appears that when: 1) The user has no bookmarks 2 node in PEP 2) The client publishes an empty bookmark set to a legacy bookmarks location 3) mod_bookmarks will attempt to purge items from the non-existent node and log an error about the failure (item-not-found). This new code will suppress an item-not-found error from the purge operation in the empty-bookmarks case, and adds a log message for any other error (this is helpful because the existing log message confusingly says it was an error *publishing* to the node, which isn't always accurate).

# mod_scansion_record on host 'localhost' recording started 2022-07-26T21:39:55Z

[Client] Romeo
	password: password
	jid: juliet@localhost/UaksS4M1xYZB

-----

Romeo connects

Romeo sends:
	<iq xml:lang='en' type='get' id='bNBJLtpIJXpq'>
		<pubsub xmlns='http://jabber.org/protocol/pubsub'>
			<items node='storage:bookmarks'/>
		</pubsub>
	</iq>

Romeo receives:
	<iq id='bNBJLtpIJXpq' type='error'>
		<error type='cancel'>
			<item-not-found xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
		</error>
	</iq>

Romeo disconnects

# recording ended on 2022-07-26T21:40:45Z