prosody
11765f0605ec
spec/scansion/muc_presence_probe.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/muc_presence_probe.scs @ 12462:11765f0605ec

mod_s2s: Store real stanzas in session.sendq, rather than strings This is the "right" thing to do. Strings were more memory-efficient, but e.g. bypassed stanza filters at reconnection time. Also not being stanzas prevents us from potential future work, such as merging sendq with mod_smacks. Regarding performance: we should counter the probable negative effect of this change with other positive changes that are desired anyway - e.g. a limit on the size of the sendq, improved in-memory representation of stanzas, s2s backoff (e.g. if a remote server is persistently unreachable, cache this failure for a while and don't just keep forever queuing stanzas for it).
author Matthew Wild <mwild1@gmail.com>
date Wed, 23 Mar 2022 15:25:22 +0000
parent 11246:ab189e707705
line wrap: on
line source

# #1535 Let MUCs respond to presence probes

[Client] Romeo
	jid: user@localhost
	password: password

[Client] Juliet
	jid: user2@localhost
	password: password

[Client] Mercutio
	jid: user3@localhost
	password: password

-----

Romeo connects

# Romeo joins the MUC

Romeo sends:
	<presence to="room@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from='room@conference.localhost/Romeo'>
		<x xmlns='http://jabber.org/protocol/muc#user'>
			<status code='201'/>
			<item jid="${Romeo's full JID}" affiliation='owner' role='moderator'/>
			<status code='110'/>
		</x>
	</presence>

Romeo receives:
	<message type='groupchat' from='room@conference.localhost'><subject/></message>

# Disable presences for non-mods
Romeo sends:
	<iq id='config1' to='room@conference.localhost' type='set'>
		<query xmlns='http://jabber.org/protocol/muc#owner'>
			<x xmlns='jabber:x:data' type='submit'>
				<field var='FORM_TYPE'>
					<value>http://jabber.org/protocol/muc#roomconfig</value>
				</field>
				<field var='muc#roomconfig_presencebroadcast'>
					<value>moderator</value>
				</field>
			</x>
		</query>
	</iq>

Romeo receives:
	<iq id="config1" from="room@conference.localhost" type="result">
	</iq>

# Romeo probes himself

Romeo sends:
	<presence to="room@conference.localhost/Romeo" type="probe">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from='room@conference.localhost/Romeo'>
		<x xmlns='http://jabber.org/protocol/muc#user'>
			<item jid="${Romeo's full JID}" affiliation='owner' role='moderator'/>
		</x>
	</presence>

# Juliet tries to probe Romeo before joining the room

Juliet connects

Juliet sends:
	<presence to="room@conference.localhost/Romeo" type="probe">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Juliet receives:
	<presence from="room@conference.localhost/Romeo" type="error">
		<error type="cancel">
			<not-acceptable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
		</error>
	</presence>

# Juliet tries to probe Mercutio (who's not in the MUC) before joining the room

Juliet sends:
	<presence to="room@conference.localhost/Mercutio" type="probe">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Juliet receives:
	<presence from="room@conference.localhost/Mercutio" type="error">
		<error type="cancel">
			<not-acceptable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
		</error>
	</presence>

# Juliet joins the room

Juliet sends:
	<presence to="room@conference.localhost/Juliet">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Juliet receives:
	<presence from="room@conference.localhost/Romeo" />

Juliet receives:
	<presence from="room@conference.localhost/Juliet" />

# Romeo probes Juliet

Romeo sends:
	<presence to="room@conference.localhost/Juliet" type="probe">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from='room@conference.localhost/Juliet'>
		<x xmlns='http://jabber.org/protocol/muc#user'>
			<item jid="${Juliet's full JID}" affiliation='none' role='participant'/>
		</x>
	</presence>


# Mercutio tries to probe himself in a MUC before joining

Mercutio connects

Mercutio sends:
	<presence to="room@conference.localhost/Mercutio" type="probe">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Mercutio receives:
	<presence from="room@conference.localhost/Mercutio" type="error">
		<error type="cancel">
			<not-acceptable xmlns="urn:ietf:params:xml:ns:xmpp-stanzas"/>
		</error>
	</presence>


# Romeo makes Mercutio a member and registers his nickname

Romeo sends:
	<iq id='member1' to='room@conference.localhost' type='set'>
		<query xmlns='http://jabber.org/protocol/muc#admin'>
			<item affiliation='member' jid="${Mercutio's JID}" nick="Mercutio"/>
		</query>
	</iq>

Romeo receives:
	<message from='room@conference.localhost'>
		<x xmlns='http://jabber.org/protocol/muc#user'>
			<item jid="${Mercutio's JID}" affiliation='member' />
		</x>
	</message>

Romeo receives:
	<iq from='room@conference.localhost' id='member1' type='result'/>


# Romeo probes Mercutio, even though he's unavailable

Romeo sends:
	<presence to="room@conference.localhost/Mercutio" type="probe">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from='room@conference.localhost/Mercutio' type="unavailable">
		<x xmlns='http://jabber.org/protocol/muc#user'>
			<item nick="Mercutio" affiliation='member' role='none' jid="${Mercutio's JID}" />
		</x>
	</presence>