prosody
11765f0605ec
spec/scansion/muc_nickname_robotface.scs

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

File

spec/scansion/muc_nickname_robotface.scs @ 12462:11765f0605ec

mod_s2s: Store real stanzas in session.sendq, rather than strings This is the "right" thing to do. Strings were more memory-efficient, but e.g. bypassed stanza filters at reconnection time. Also not being stanzas prevents us from potential future work, such as merging sendq with mod_smacks. Regarding performance: we should counter the probable negative effect of this change with other positive changes that are desired anyway - e.g. a limit on the size of the sendq, improved in-memory representation of stanzas, s2s backoff (e.g. if a remote server is persistently unreachable, cache this failure for a while and don't just keep forever queuing stanzas for it).
author Matthew Wild <mwild1@gmail.com>
date Wed, 23 Mar 2022 15:25:22 +0000
parent 11411:f1fe37916501
line wrap: on
line source

# MUC: Prevent nicknames failing strict resourceprep

[Client] Romeo
	jid: user@localhost
	password: password

[Client] Roboteo
	jid: bot@localhost
	password: password

-----

Romeo connects

Romeo sends:
	<presence to="nobots@conference.localhost/Romeo">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Romeo receives:
	<presence from='nobots@conference.localhost/Romeo'>
		<x xmlns='http://jabber.org/protocol/muc#user'>
			<status code='201'/>
			<item jid="${Romeo's full JID}" affiliation='owner' role='moderator'/>
			<status code='110'/>
		</x>
	</presence>

Romeo receives:
	<message type='groupchat' from='nobots@conference.localhost'><subject/></message>

Roboteo connects

Roboteo sends:
	<presence to="nobots@conference.localhost/🤖️">
		<x xmlns="http://jabber.org/protocol/muc"/>
	</presence>

Roboteo receives:
	<presence type='error' from='nobots@conference.localhost/🤖'>
		<error by='nobots@conference.localhost' type='modify'>
			<jid-malformed xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/>
			<text xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'>Nickname must pass strict validation</text>
		</error>
	</presence>