Software /
code /
prosody
File
spec/scansion/extdisco.scs @ 12462:11765f0605ec
mod_s2s: Store real stanzas in session.sendq, rather than strings
This is the "right" thing to do. Strings were more memory-efficient, but
e.g. bypassed stanza filters at reconnection time. Also not being stanzas
prevents us from potential future work, such as merging sendq with mod_smacks.
Regarding performance: we should counter the probable negative effect of this
change with other positive changes that are desired anyway - e.g. a limit on
the size of the sendq, improved in-memory representation of stanzas, s2s
backoff (e.g. if a remote server is persistently unreachable, cache this
failure for a while and don't just keep forever queuing stanzas for it).
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 23 Mar 2022 15:25:22 +0000 |
parent | 11753:c4599a7c534c |
line wrap: on
line source
# XEP-0215: External Service Discovery [Client] Romeo password: password jid: user@localhost/mFquWxSr ----- Romeo connects Romeo sends: <iq type='get' xml:lang='sv' id='lx2' to='localhost'> <services xmlns='urn:xmpp:extdisco:2'/> </iq> Romeo receives: <iq type='result' id='lx2' from='localhost'> <services xmlns='urn:xmpp:extdisco:2'> <service host='default.example' transport='udp' port='9876' type='stun'/> <service port='9876' type='turn' restricted='1' password='yHYYBDN7M3mdlug0LTdJbW0GvvQ=' transport='udp' host='default.example' username='1219525744'/> <service port='9876' type='turn' restricted='1' password='1Uc6QfrDhIlbK97rGCUQ/cUICxs=' transport='udp' host='default.example' username='1219525744'/> <service port='2121' type='ftp' restricted='1' password='password' transport='tcp' host='default.example' username='john'/> <service port='21' type='ftp' restricted='1' password='password' transport='tcp' host='ftp.example.com' username='john'/> </services> </iq> Romeo sends: <iq type='get' xml:lang='sv' id='lx3' to='localhost'> <services xmlns='urn:xmpp:extdisco:2' type='ftp'/> </iq> Romeo receives: <iq type='result' id='lx3' from='localhost'> <services xmlns='urn:xmpp:extdisco:2'> <service port='2121' type='ftp' restricted='1' password='password' transport='tcp' host='default.example' username='john'/> <service port='21' type='ftp' restricted='1' password='password' transport='tcp' host='ftp.example.com' username='john'/> </services> </iq> Romeo sends: <iq type='get' xml:lang='sv' id='lx4' to='localhost'> <credentials xmlns='urn:xmpp:extdisco:2'> <service host='default.example' type='turn'/> </credentials> </iq> Romeo receives: <iq type='result' id='lx4' from='localhost'> <credentials xmlns='urn:xmpp:extdisco:2'> <service port='9876' type='turn' restricted='1' password='yHYYBDN7M3mdlug0LTdJbW0GvvQ=' transport='udp' host='default.example' username='1219525744'/> <service port='9876' type='turn' restricted='1' password='1Uc6QfrDhIlbK97rGCUQ/cUICxs=' transport='udp' host='default.example' username='1219525744'/> </credentials> </iq> Romeo sends: <iq type='get' xml:lang='sv' id='lx5' to='localhost'> <credentials xmlns='urn:xmpp:extdisco:2'> <service host='default.example' /> </credentials> </iq> Romeo receives: <iq type='error' id='lx5' from='localhost'> <error type='modify'> <bad-request xmlns='urn:ietf:params:xml:ns:xmpp-stanzas'/> </error> </iq> Romeo disconnects # recording ended on 2020-07-18T16:47:57Z