prosody
0dc80024fdd2
.semgrep.yml
Software / code / prosody
File
.semgrep.yml @ 12739:0dc80024fdd2
Backed out changeset 1bc2220cd6ec
The use of the error helpers creates an `<error/>` child element
containing the error condition. This is however not allowed as per
XEP-0198, which specifies that the error condition is to be a direct
child of the `<failed/>` stream management element.
This has triggered a fun reconnect loop in aioxmpp where it was
reported by a user [1].
[1]: https://github.com/horazont/aioxmpp/issues/382
| author | Jonas Schäfer <jonas@wielicki.name> |
|---|---|
| date | Mon, 03 Oct 2022 12:55:11 +0200 |
| parent | 12717:898e99f49d80 |
line wrap: on
line source
rules: - id: log-variable-fmtstring patterns: - pattern: log("...", $A) - pattern-not: log("...", "...") message: Variable passed as format string to logging languages: [lua] severity: ERROR - id: module-log-variable-fmtstring patterns: - pattern: module:log("...", $A) - pattern-not: module:log("...", "...") message: Variable passed as format string to logging languages: [lua] severity: ERROR - id: module-getopt-string-default patterns: - pattern: module:get_option_string("...", $A) - pattern-not: module:get_option_string("...", "...") - pattern-not: module:get_option_string("...", host) - pattern-not: module:get_option_string("...", module.host) message: Non-string default from :get_option_string severity: ERROR languages: [lua] - id: stanza-empty-text-constructor patterns: - pattern: $A:text() message: Use :get_text() to read text, or pass a value here to add text severity: WARNING languages: [lua]
