Diff

plugins/mod_dialback.lua @ 7087:dd8265ca9327

mod_dialback: Follow XEP-0185 and use HMAC
author Kim Alvefur <zash@zash.se>
date Tue, 19 Jan 2016 21:31:02 +0100
parent 6424:89c42aff8510
child 7106:74798480b52e
line wrap: on
line diff
--- a/plugins/mod_dialback.lua	Sat Jan 16 22:43:11 2016 +0100
+++ b/plugins/mod_dialback.lua	Tue Jan 19 21:31:02 2016 +0100
@@ -12,6 +12,7 @@
 
 local st = require "util.stanza";
 local sha256_hash = require "util.hashes".sha256;
+local sha256_hmac = require "util.hashes".hmac_sha256;
 local nameprep = require "util.encodings".stringprep.nameprep;
 local check_cert_status = module:depends"s2s".check_cert_status;
 local uuid_gen = require"util.uuid".generate;
@@ -20,7 +21,7 @@
 
 local dialback_requests = setmetatable({}, { __mode = 'v' });
 
-local dialback_secret = module.host .. module:get_option_string("dialback_secret", uuid_gen());
+local dialback_secret = sha256_hash(module:get_option_string("dialback_secret", uuid_gen()), true);
 local dwd = module:get_option_boolean("dialback_without_dialback", false);
 
 function module.save()
@@ -32,7 +33,7 @@
 end
 
 function generate_dialback(id, to, from)
-	return sha256_hash(id..to..dialback_secret, true);
+	return sha256_hmac(dialback_secret, to .. ' ' .. from .. ' ' .. id, true);
 end
 
 function initiate_dialback(session)