Diff

core/s2smanager.lua @ 1805:7e41ad68fe3c

core.s2smanager: Don't recurse CNAMEs infinitely :)
author Matthew Wild <mwild1@gmail.com>
date Mon, 21 Sep 2009 14:40:14 +0100
parent 1796:5f7b2f940816
child 1806:c55e06eb53b2
child 1828:48cb27e2716e
line wrap: on
line diff
--- a/core/s2smanager.lua	Mon Sep 21 13:53:59 2009 +0100
+++ b/core/s2smanager.lua	Mon Sep 21 14:40:14 2009 +0100
@@ -41,6 +41,7 @@
 
 local connect_timeout = config.get("*", "core", "s2s_timeout") or 60;
 local dns_timeout = config.get("*", "core", "dns_timeout") or 60;
+local max_dns_depth = config.get("*", "core", "dns_max_depth") or 3;
 
 incoming_s2s = {};
 local incoming_s2s = incoming_s2s;
@@ -254,9 +255,12 @@
 		
 		-- COMPAT: This is a compromise for all you CNAME-(ab)users :)
 		if not (reply and reply[1] and reply[1].a) then
+			local count = max_dns_depth;
 			reply = dns.peek(connect_host, "CNAME", "IN");
-			while reply and reply[1] and not reply[1].a and reply[1].cname do
+			while count > 0 and reply and reply[1] and not reply[1].a and reply[1].cname do
+				log("debug", "Looking up %s (DNS depth is %d)", tostring(reply[1].cname), count);
 				reply = dns.peek(reply[1].cname, "A", "IN") or dns.peek(reply[1].cname, "CNAME", "IN");
+				count = count - 1;
 			end
 		end
 		-- end of CNAME resolving