prosody
7d985e5bc1fb
util/statsd.lua

Find changesets by keywords by author, files, the commit message, revision number or hash, or revset expression.

Software / code / prosody

Diff

util/statsd.lua @ 12124:7d985e5bc1fb

openmetrics/histograms: improve code clarity If buckets thresholds are to be taken as "less than or equal to", then using the less than or equal to operator seems sensible.
author Kim Alvefur <zash@zash.se>
date Mon, 27 Dec 2021 16:05:12 +0100
parent 12123:7ba686696250
child 12387:05c250fa335a
line wrap: on
line diff
--- a/util/statsd.lua	Sun Dec 26 22:32:00 2021 +0100
+++ b/util/statsd.lua	Mon Dec 27 16:05:12 2021 +0100
@@ -115,7 +115,7 @@
 function histogram_metric_mt:sample(value)
 	-- According to the I-D, values must be part of all buckets
 	for i, bucket in pairs(self) do
-		if "number" == type(i) and bucket.threshold >= value then
+		if "number" == type(i) and value <= bucket.threshold then
 			bucket.count = bucket.count + 1
 			self._impl:push_counter_delta(bucket._full_name, 1)
 		end