Software / code / prosody
Diff
plugins/mod_http_file_share.lua @ 11493:77f2d45799ed
mod_http_file_share: Fix reporting of missing files
This just gave an unhelpful 500 error.
It would be nice to have some wrapper code that could untangle the
embedded filename in the io libs errors.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Sun, 28 Mar 2021 13:51:06 +0200 |
| parent | 11491:c3fb802f9e45 |
| child | 11495:6d3f84148729 |
line wrap: on
line diff
--- a/plugins/mod_http_file_share.lua Sun Mar 28 13:22:35 2021 +0200 +++ b/plugins/mod_http_file_share.lua Sun Mar 28 13:51:06 2021 +0200 @@ -339,9 +339,12 @@ return 304; end local filename = get_filename(slot_id); - local handle, ferr = errors.coerce(io.open(filename)); + local handle, ferr = io.open(filename); if not handle then - return ferr or 410; + module:log("error", "Could not open file: %s", filename, ferr); + -- This can be because the upload slot wasn't used, or the file disappeared + -- somehow, or permission issues. + return 410; end if not filetype then
