Diff

plugins/mod_c2s.lua @ 13575:750ff9f579e2

mod_c2s, mod_s2s: Support for queuing callbacks to run in session thread This allows certain session-specific code that needs to run in the async context, but is itself triggered outside of that context (e.g. timers), to be queued. An example of this is the session destruction code of mod_smacks, when the hibernation timeout is reached.
author Matthew Wild <mwild1@gmail.com>
date Thu, 21 Nov 2024 17:02:07 +0000
parent 13504:2159a206684e
child 13642:1b2de94f0580
line wrap: on
line diff
--- a/plugins/mod_c2s.lua	Wed Nov 20 12:08:59 2024 +0000
+++ b/plugins/mod_c2s.lua	Thu Nov 21 17:02:07 2024 +0000
@@ -45,6 +45,7 @@
 local stream_callbacks = { default_ns = "jabber:client" };
 local listener = {};
 local runner_callbacks = {};
+local session_events = {};
 
 local m_tls_params = module:metric(
 	"counter", "encrypted", "",
@@ -76,11 +77,11 @@
 
 function stream_callbacks.streamopened(session, attr)
 	-- run _streamopened in async context
-	session.thread:run({ stream = "opened", attr = attr });
+	session.thread:run({ event = "streamopened", attr = attr });
 end
 
-function stream_callbacks._streamopened(session, attr)
-	local send = session.send;
+function session_events.streamopened(session, event)
+	local send, attr = session.send, event.attr;
 	if not attr.to then
 		session:close{ condition = "improper-addressing",
 			text = "A 'to' attribute is required on stream headers" };
@@ -162,14 +163,19 @@
 
 function stream_callbacks.streamclosed(session, attr)
 	-- run _streamclosed in async context
-	session.thread:run({ stream = "closed", attr = attr });
+	session.thread:run({ event = "streamclosed", attr = attr });
 end
 
-function stream_callbacks._streamclosed(session)
+function session_events.streamclosed(session)
 	session.log("debug", "Received </stream:stream>");
 	session:close(false);
 end
 
+function session_events.callback(session, event)
+	session.log("debug", "Running session callback %s", event.name);
+	event.callback(session, event);
+end
+
 function stream_callbacks.error(session, error, data)
 	if error == "no-stream" then
 		session.log("debug", "Invalid opening stream header (%s)", (data:gsub("^([^\1]+)\1", "{%1}")));
@@ -350,13 +356,11 @@
 		session.stream:reset();
 	end
 
-	session.thread = runner(function (stanza)
-		if st.is_stanza(stanza) then
-			core_process_stanza(session, stanza);
-		elseif stanza.stream == "opened" then
-			stream_callbacks._streamopened(session, stanza.attr);
-		elseif stanza.stream == "closed" then
-			stream_callbacks._streamclosed(session, stanza.attr);
+	session.thread = runner(function (item)
+		if st.is_stanza(item) then
+			core_process_stanza(session, item);
+		else
+			session_events[item.event](session, item);
 		end
 	end, runner_callbacks, session);