Software / code / prosody
Diff
plugins/mod_smacks.lua @ 12136:6366240d2edb
mod_smacks: Limit "old" session resumption counters
Doing this when creating a whole new session seems reasonable because it
is already expensive and this is when it may be adding to the old
session store, while a successful resumption should be plus-minus zero.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Fri, 31 Dec 2021 00:48:38 +0100 |
| parent | 12135:fa804c2db747 |
| child | 12137:4e61aaa4e9b2 |
line wrap: on
line diff
--- a/plugins/mod_smacks.lua Fri Dec 31 00:18:13 2021 +0100 +++ b/plugins/mod_smacks.lua Fri Dec 31 00:48:38 2021 +0100 @@ -52,6 +52,7 @@ local timer = require "util.timer"; local new_id = require "util.id".short; local watchdog = require "util.watchdog"; +local it = require"util.iterators"; local sessionmanager = require "core.sessionmanager"; local core_process_stanza = prosody.core_process_stanza; @@ -72,12 +73,14 @@ local max_unacked_stanzas = module:get_option_number("smacks_max_unacked_stanzas", 0); local max_inactive_unacked_stanzas = module:get_option_number("smacks_max_inactive_unacked_stanzas", 256); local delayed_ack_timeout = module:get_option_number("smacks_max_ack_delay", 30); +local max_old_sessions = module:get_option_number("smacks_max_old_sessions", 10); local c2s_sessions = module:shared("/*/c2s/sessions"); local local_sessions = prosody.hosts[module.host].sessions; local function format_h(h) if h then return string.format("%d", h) end end +local all_old_sessions = module:open_store("smacks_h"); local old_session_registry = module:open_store("smacks_h", "map"); local session_registry = module:shared "/*/smacks/resumption-tokens"; -- > user@host/resumption-token --> resource @@ -281,6 +284,22 @@ return true; end + if session.username then + local old_sessions, err = all_old_sessions:get(session.username); + module:log("debug", "Old sessions: %q", old_sessions) + if old_sessions then + local keep, count = {}, 0; + for token, info in it.sorted_pairs(old_sessions, function(a, b) + return (old_sessions[a].t or 0) > (old_sessions[b].t or 0); + end) do + count = count + 1; + if count > max_old_sessions then break end + keep[token] = info; + end + all_old_sessions:set(session.username, keep); + end + end + module:log("debug", "Enabling stream management"); session.smacks = xmlns_sm;
