Comparison

util.stanza: Check that argument to error_reply is NOT a stanza of type error Replying to an error is Very Bad

comparison

equal deleted inserted replaced

-:4eab1f5a4f3b
+:f53c03ab4357
 		it("should reject not-stanzas", function ()
 			assert.has.error_match(function ()
 				st.error_reply(not "a stanza", "modify", "bad-request");
 			end, "expected stanza");
 		end);
+		it("should reject stanzas of type error", function ()
+			assert.has.error_match(function ()
+				st.error_reply(st.message({type="error"}), "cancel", "conflict");
+			end, "got stanza of type error");
+			assert.has.error_match(function ()
+				st.error_reply(st.error_reply(st.message({type="chat"}), "modify", "forbidden"), "cancel", "service-unavailable");
+			end, "got stanza of type error");
+		end);
 	end);
 	describe("should reject #invalid", function ()
 		local invalid_names = {
 			["empty string"] = "", ["characters"] = "<>";