Comparison

mod_blocklist: Expand comments on caching of blocklists

comparison

equal deleted inserted replaced

-:31d8e1a8a014
+:cde7d14052f9
 local jid_split = require"util.jid".split;
 local storage = module:open_store();
 local sessions = prosody.hosts[module.host].sessions;
--- Cache of blocklists by username may randomly expire at any time
+-- First level cache of blocklists by username.
+-- Weak table so may randomly expire at any time.
 local cache = setmetatable({}, { __mode = "v" });
--- Second level of caching, keeps a fixed number of items,
+-- Second level of caching, keeps a fixed number of items, also anchors
--- also anchors items in the above cache
+-- items in the above cache.
+--
+-- The size of this affects how often we will need to load a blocklist from
+-- disk, which we want to avoid during routing. On the other hand, we don't
+-- want to use too much memory either, so this can be tuned by advanced
+-- users. TODO use science to figure out a better default, 64 is just a guess.
 local cache_size = module:get_option_number("blocklist_cache_size", 64);
 local cache2 = require"util.cache".new(cache_size);
 local null_blocklist = {};