Comparison

mod_component: xpcall() stanza processing, as per other listeners, preventing potentially harmful 'top-level errors'

comparison

equal deleted inserted replaced

-:579c51cbc12c
+:a49f32e3d73b
 --
 module:set_global();
 local t_concat = table.concat;
+local traceback = debug.traceback;
 local logger = require "util.logger";
 local sha1 = require "util.hashes".sha1;
 local st = require "util.stanza";
 function stream_callbacks.streamclosed(session)
 	session.log("debug", "Received </stream:stream>");
 	session:close();
 end
+local function handleerr(err) log("error", "Traceback[component]: %s", traceback(tostring(err), 2)); end
 function stream_callbacks.handlestanza(session, stanza)
 	-- Namespaces are icky.
 	if not stanza.attr.xmlns and stanza.name == "handshake" then
 		stanza.attr.xmlns = xmlns_component;
 	end
 			session.log("warn", "Rejecting stanza with no 'to' address");
 			session.send(st.error_reply(stanza, "modify", "bad-request", "Components MUST specify a 'to' address on stanzas"));
 			return;
 		end
 	end
-	return core_process_stanza(session, stanza);
+	if stanza then
+		return xpcall(function () return core_process_stanza(session, stanza) end, handleerr);
+	end
 end
 --- Closing a component connection
 local stream_xmlns_attr = {xmlns='urn:ietf:params:xml:ns:xmpp-streams'};
 local default_stream_attr = { ["xmlns:stream"] = "http://etherx.jabber.org/streams", xmlns = stream_callbacks.default_ns, version = "1.0", id = "" };