Comparison

mod_storage_sql: Record connection to database as module status Allows retrieving this in e.g. a health reporting module Thanks pfak

comparison

equal deleted inserted replaced

-:885323e2a1ce
+:a20923f7d5fd
 	return true;
 end
 function engine:onconnect() -- luacheck: ignore 212/self
 	-- Override from create_engine()
 end
+function engine:ondisconnect() -- luacheck: ignore 212/self
+	-- Override from create_engine()
+end
 function engine:prepquery(sql)
 	if self.params.driver == "MySQL" then
 		sql = sql:gsub("\"", "`");
 	end
 	if not ok then
 		local conn = self.conn;
 		if not conn or not conn:ping() then
 			log("debug", "Database connection was closed. Will reconnect and retry.");
 			self.conn = nil;
+			self:ondisconnect();
 			log("debug", "Retrying SQL transaction [%s]", (...));
 			ok, ret, b, c = self:_transaction(...);
 			log("debug", "SQL transaction retry %s", ok and "succeeded" or "failed");
 		else
 			log("debug", "SQL connection is up, so not retrying");
 		port = params.port,
 		path = params.database,
 	};
 end
-local function create_engine(_, params, onconnect)
+local function create_engine(_, params, onconnect, ondisconnect)
-	return setmetatable({ url = db2uri(params), params = params, onconnect = onconnect }, engine_mt);
+	return setmetatable({ url = db2uri(params); params = params; onconnect = onconnect; ondisconnect = ondisconnect }, engine_mt);
 end
 return {
 	is_column = is_column;
 	is_index = is_index;