Comparison

mod_s2s: Close offending s2s streams missing an 'id' attribute with a stream error instead of throwing an unhandled error

comparison

equal deleted inserted replaced

-:84c50a9addbc
+:3cec0eef0b70
 			send(features);
 		end
 		session.notopen = nil;
 	elseif session.direction == "outgoing" then
 		session.notopen = nil;
-		-- If we are just using the connection for verifying dialback keys, we won't try and auth it
+		if not attr.id then
-		if not attr.id then error("stream response did not give us a streamid!!!"); end
+			log("error", "Stream response did not give us a stream id!");
+			session:close({ condition = "undefined-condition", text = "Missing stream ID" });
+			return;
+		end
 		session.streamid = attr.id;
 		if session.secure and not session.cert_chain_status then
 			if check_cert_status(session) == false then
 				return;