Comparison

mod_s2s: Remove connection from sessions table as soon as we learn it is disconnected. Fixes a connection/session leak.

comparison

equal deleted inserted replaced

-:1e555909f23d
+:0d08c0965824
 end
 function listener.ondisconnect(conn, err)
 	local session = sessions[conn];
 	if session then
+		sessions[conn] = nil;
 		if err and session.direction == "outgoing" and session.notopen then
 			(session.log or log)("debug", "s2s connection attempt failed: %s", err);
 			if s2sout.attempt_connection(session, err) then
 				(session.log or log)("debug", "...so we're going to try another target");
 				return; -- Session lives for now
 			end
 		end
 		(session.log or log)("debug", "s2s disconnected: %s->%s (%s)", tostring(session.from_host), tostring(session.to_host), tostring(err or "connection closed"));
 		s2s_destroy_session(session, err);
-		sessions[conn] = nil;
 	end
 end
 function listener.register_outgoing(conn, session)
 	session.direction = "outgoing";