Software / code / prosody
Annotate
net/httpserver.lua @ 11405:ce8291e89d67
mod_http_file_share: Remove correct entries when not all expired files were deleted
If any of the expired files could not be deleted then we should not
forget about that, we should complain loudly and try again.
The code got this backwards and would have removed only the entries
referring to still existing files.
Test procedure:
1. Upload a file
2. chown root:root http_file_share/
3. In uploads.list, decrease 'when' enough to ensure expiry
4. Reload mod_http_file_share
5. Should see an error in the logs about failure to delete the file
6. Should see that the metadata in uploads.list is still there
7. chown http_file_share/ back to the previous owner
8. Reload mod_http_file_share
9. Should see logs about successful removal of expired file
10. Should see that the metadata in uploads.list is gone
11. Should see that the file was deleted
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Thu, 25 Feb 2021 23:58:08 +0100 |
| parent | 8679:adc17a2bd6fd |
| child | 12974:ba409c67353b |
| rev | line source |
|---|---|
|
4784
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
1 -- COMPAT w/pre-0.9 |
|
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
2 local log = require "util.logger".init("net.httpserver"); |
|
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
3 local traceback = debug.traceback; |
|
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
4 |
|
6780
647adfd8f738
net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents:
4797
diff
changeset
|
5 local _ENV = nil; |
|
8555
4f0f5b49bb03
vairious: Add annotation when an empty environment is set [luacheck]
Kim Alvefur <zash@zash.se>
parents:
7359
diff
changeset
|
6 -- luacheck: std none |
|
4784
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
7 |
|
8679
adc17a2bd6fd
net.httpserver: Make function local, fixes loading since there is no environment [luacheck]
Kim Alvefur <zash@zash.se>
parents:
8555
diff
changeset
|
8 local function fail() |
|
7359
a5a080c12c96
Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents:
6780
diff
changeset
|
9 log("error", "Attempt to use legacy HTTP API. For more info see https://prosody.im/doc/developers/legacy_http"); |
|
4784
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
10 log("error", "Legacy HTTP API usage, %s", traceback("", 2)); |
|
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
11 end |
|
e10b623ccecb
net.httpserver: Add compatibility stub
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
12 |
|
6780
647adfd8f738
net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents:
4797
diff
changeset
|
13 return { |
|
647adfd8f738
net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents:
4797
diff
changeset
|
14 new = fail; |
|
647adfd8f738
net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents:
4797
diff
changeset
|
15 new_from_config = fail; |
|
647adfd8f738
net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents:
4797
diff
changeset
|
16 set_default_handler = fail; |
|
647adfd8f738
net.*: Remove use of module() function
Kim Alvefur <zash@zash.se>
parents:
4797
diff
changeset
|
17 }; |
