Software / code / prosody
Annotate
HACKERS @ 11405:ce8291e89d67
mod_http_file_share: Remove correct entries when not all expired files were deleted
If any of the expired files could not be deleted then we should not
forget about that, we should complain loudly and try again.
The code got this backwards and would have removed only the entries
referring to still existing files.
Test procedure:
1. Upload a file
2. chown root:root http_file_share/
3. In uploads.list, decrease 'when' enough to ensure expiry
4. Reload mod_http_file_share
5. Should see an error in the logs about failure to delete the file
6. Should see that the metadata in uploads.list is still there
7. chown http_file_share/ back to the previous owner
8. Reload mod_http_file_share
9. Should see logs about successful removal of expired file
10. Should see that the metadata in uploads.list is gone
11. Should see that the file was deleted
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Thu, 25 Feb 2021 23:58:08 +0100 |
| parent | 9858:54147de1d1b1 |
| rev | line source |
|---|---|
| 13 | 1 Welcome hackers! |
| 2 | |
| 1082 | 3 This project accepts and *encourages* contributions. If you would like to get |
| 4 involved you can join us on our mailing list and discussion rooms. More | |
|
7359
a5a080c12c96
Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents:
2664
diff
changeset
|
5 information on these at https://prosody.im/discuss |
| 13 | 6 |
| 1082 | 7 Patches are welcome, though before sending we would appreciate if you read |
|
9858
54147de1d1b1
doc/coding_style.{txt,md}: Update coding style guide
Matthew Wild <mwild1@gmail.com>
parents:
7359
diff
changeset
|
8 docs/coding_style.md for guidelines on how to format your code, and other tips. |
| 2664 | 9 |
|
7359
a5a080c12c96
Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents:
2664
diff
changeset
|
10 Documentation for developers can be found at https://prosody.im/doc/developers |
| 2664 | 11 |
| 12 Have fun :) |