Annotate

HACKERS @ 12579:ca6a43fe0231 0.12

util.jsonschema: Fix validation to not assume presence of "type" field MattJ reported a curious issue where validation did not work as expected. Primarily that the "type" field was expected to be mandatory, and thus leaving it out would result in no checks being performed. This was likely caused by misreading during initial development. Spent some time testing against https://github.com/json-schema-org/JSON-Schema-Test-Suite.git and discovered a multitude of issues, far too many to bother splitting into separate commits. More than half of them fail. Many because of features not implemented, which have been marked NYI. For example, some require deep comparisons e.g. when objects or arrays are present in enums fields. Some because of quirks with how Lua differs from JavaScript, e.g. no distinct array or object types. Tests involving fractional floating point numbers. We're definitely not going to follow references to remote resources. Or deal with UTF-16 sillyness. One test asserted that 1.0 is an integer, where Lua 5.3+ will disagree.
author Kim Alvefur <zash@zash.se>
date Fri, 08 Jul 2022 14:38:23 +0200
parent 9858:54147de1d1b1
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 Welcome hackers!
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
3 This project accepts and *encourages* contributions. If you would like to get
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
4 involved you can join us on our mailing list and discussion rooms. More
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
5 information on these at https://prosody.im/discuss
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
7 Patches are welcome, though before sending we would appreciate if you read
9858
54147de1d1b1 doc/coding_style.{txt,md}: Update coding style guide
Matthew Wild <mwild1@gmail.com>
parents: 7359
diff changeset
8 docs/coding_style.md for guidelines on how to format your code, and other tips.
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
9
7359
a5a080c12c96 Update every link to the documentation to use HTTPS
Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>
parents: 2664
diff changeset
10 Documentation for developers can be found at https://prosody.im/doc/developers
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
11
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
12 Have fun :)