Software /
code /
prosody
Annotate
.semgrep.yml @ 13461:c673ff1075bd
mod_posix: Move everything to util.startup
This allows greater control over the order of events.
Notably, the internal ordering between daemonization, initialization of
libunbound and setup of signal handling is sensitive.
libunbound starts a separate thread for processing DNS requests.
If this thread is started before signal handling has been set up, it
will not inherit the signal handlers and instead behave as it would have
before signal handlers were set up, i.e. cause the whole process to
immediately exit.
libunbound is usually initialized on the first DNS request, usually
triggered by an outgoing s2s connection attempt.
If daemonization happens before signals have been set up, signals may
not be processed at all.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sat, 23 Mar 2024 20:48:19 +0100 |
parent | 12717:898e99f49d80 |
child | 13700:9b7687b47da9 |
rev | line source |
---|---|
11289 | 1 rules: |
2 - id: log-variable-fmtstring | |
3 patterns: | |
4 - pattern: log("...", $A) | |
5 - pattern-not: log("...", "...") | |
6 message: Variable passed as format string to logging | |
7 languages: [lua] | |
8 severity: ERROR | |
9 - id: module-log-variable-fmtstring | |
10 patterns: | |
11 - pattern: module:log("...", $A) | |
12 - pattern-not: module:log("...", "...") | |
13 message: Variable passed as format string to logging | |
14 languages: [lua] | |
15 severity: ERROR | |
16 - id: module-getopt-string-default | |
17 patterns: | |
18 - pattern: module:get_option_string("...", $A) | |
19 - pattern-not: module:get_option_string("...", "...") | |
20 - pattern-not: module:get_option_string("...", host) | |
21 - pattern-not: module:get_option_string("...", module.host) | |
22 message: Non-string default from :get_option_string | |
23 severity: ERROR | |
24 languages: [lua] | |
12717
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
25 - id: stanza-empty-text-constructor |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
26 patterns: |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
27 - pattern: $A:text() |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
28 message: Use :get_text() to read text, or pass a value here to add text |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
29 severity: WARNING |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
30 languages: [lua] |