Software / code / prosody
Annotate
.semgrep.yml @ 11906:ba3344926e18
MUC: Add option to include form in registration query
This was originally not done based on my interpretation of XEP-0045. Today's
reading, however, revealed that it actually says the result
> SHOULD contain **at least** a <username/> element
(emphasis mine)
I take this to mean that including a form **is** allowed (and I think this is
sensible). Tigase already includes the form I believe.
I've gated the new behaviour behind a (default off) option, because it hasn't
been tested for compatibility with clients. My primary desire for it is in
Snikket, where the clients will be tested to ensure compatibility with this.
I don't anticipate that (m)any clients would break, so maybe after 0.12 we can
experiment with enabling it by default and eventually remove the option.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Mon, 15 Nov 2021 16:11:03 +0000 |
| parent | 11289:c6965f3c321c |
| child | 12717:898e99f49d80 |
| rev | line source |
|---|---|
| 11289 | 1 rules: |
| 2 - id: log-variable-fmtstring | |
| 3 patterns: | |
| 4 - pattern: log("...", $A) | |
| 5 - pattern-not: log("...", "...") | |
| 6 message: Variable passed as format string to logging | |
| 7 languages: [lua] | |
| 8 severity: ERROR | |
| 9 - id: module-log-variable-fmtstring | |
| 10 patterns: | |
| 11 - pattern: module:log("...", $A) | |
| 12 - pattern-not: module:log("...", "...") | |
| 13 message: Variable passed as format string to logging | |
| 14 languages: [lua] | |
| 15 severity: ERROR | |
| 16 - id: module-getopt-string-default | |
| 17 patterns: | |
| 18 - pattern: module:get_option_string("...", $A) | |
| 19 - pattern-not: module:get_option_string("...", "...") | |
| 20 - pattern-not: module:get_option_string("...", host) | |
| 21 - pattern-not: module:get_option_string("...", module.host) | |
| 22 message: Non-string default from :get_option_string | |
| 23 severity: ERROR | |
| 24 languages: [lua] |
