Software /
code /
prosody
Annotate
.semgrep.yml @ 13532:9970d333a63f
mod_pubsub: Use error registry
This is what util.error was made for!
This replaces the custom error stanza builder with common code in
util.stanza that knows enough about util.error and namespaced errors.
Some awkwardness remains in the way util.pubsub returns conflicting
form fields.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sun, 27 Oct 2024 15:18:24 +0100 |
parent | 12717:898e99f49d80 |
child | 13700:9b7687b47da9 |
rev | line source |
---|---|
11289 | 1 rules: |
2 - id: log-variable-fmtstring | |
3 patterns: | |
4 - pattern: log("...", $A) | |
5 - pattern-not: log("...", "...") | |
6 message: Variable passed as format string to logging | |
7 languages: [lua] | |
8 severity: ERROR | |
9 - id: module-log-variable-fmtstring | |
10 patterns: | |
11 - pattern: module:log("...", $A) | |
12 - pattern-not: module:log("...", "...") | |
13 message: Variable passed as format string to logging | |
14 languages: [lua] | |
15 severity: ERROR | |
16 - id: module-getopt-string-default | |
17 patterns: | |
18 - pattern: module:get_option_string("...", $A) | |
19 - pattern-not: module:get_option_string("...", "...") | |
20 - pattern-not: module:get_option_string("...", host) | |
21 - pattern-not: module:get_option_string("...", module.host) | |
22 message: Non-string default from :get_option_string | |
23 severity: ERROR | |
24 languages: [lua] | |
12717
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
25 - id: stanza-empty-text-constructor |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
26 patterns: |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
27 - pattern: $A:text() |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
28 message: Use :get_text() to read text, or pass a value here to add text |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
29 severity: WARNING |
898e99f49d80
semgrep: Catch stanza:text() (assuming it's meant to be :get_text())
Matthew Wild <mwild1@gmail.com>
parents:
11289
diff
changeset
|
30 languages: [lua] |