Software /
code /
prosody
Annotate
spec/core_configmanager_spec.lua @ 10224:94e341dee51c
core.certmanager: Move EECDH ciphers before EDH in default cipherstring
The original intent of having kEDH before kEECDH was that if a `dhparam`
file was specified, this would be interpreted as a preference by the
admin for old and well-tested Diffie-Hellman key agreement over newer
elliptic curve ones. Otherwise the faster elliptic curve ciphersuites
would be preferred. This didn't really work as intended since this
affects the ClientHello on outgoing s2s connections, leading to some
servers using poorly configured kEDH.
With Debian shipping OpenSSL settings that enforce a higher security
level, this caused interoperability problems with servers that use DH
params smaller than 2048 bits. E.g. jabber.org at the time of this
writing has 1024 bit DH params.
MattJ says
> Curves have won, and OpenSSL is less weird about them now
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sun, 25 Aug 2019 20:22:35 +0200 |
parent | 9168:29de7ad20250 |
child | 10495:8ea685ec0979 |
rev | line source |
---|---|
8236
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
1 |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
2 local configmanager = require "core.configmanager"; |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
3 |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
4 describe("core.configmanager", function() |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
5 describe("#get()", function() |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
6 it("should work", function() |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
7 configmanager.set("example.com", "testkey", 123); |
9168
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
8 assert.are.equal(123, configmanager.get("example.com", "testkey"), "Retrieving a set key"); |
8236
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
9 |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
10 configmanager.set("*", "testkey1", 321); |
9168
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
11 assert.are.equal(321, configmanager.get("*", "testkey1"), "Retrieving a set global key"); |
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
12 assert.are.equal(321, configmanager.get("example.com", "testkey1"), "Retrieving a set key of undefined host, of which only a globally set one exists"); |
8236
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
13 |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
14 configmanager.set("example.com", ""); -- Creates example.com host in config |
9168
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
15 assert.are.equal(321, configmanager.get("example.com", "testkey1"), "Retrieving a set key, of which only a globally set one exists"); |
8236
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
16 |
9168
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
17 assert.are.equal(nil, configmanager.get(), "No parameters to get()"); |
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
18 assert.are.equal(nil, configmanager.get("undefined host"), "Getting for undefined host"); |
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
19 assert.are.equal(nil, configmanager.get("undefined host", "undefined key"), "Getting for undefined host & key"); |
8236
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
20 end); |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
21 end); |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
22 |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
23 describe("#set()", function() |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
24 it("should work", function() |
9168
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
25 assert.are.equal(false, configmanager.set("*"), "Set with no key"); |
8236
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
26 |
9168
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
27 assert.are.equal(true, configmanager.set("*", "set_test", "testkey"), "Setting a nil global value"); |
29de7ad20250
spec: Correct order of arguments to asserts in configmanager tests
Kim Alvefur <zash@zash.se>
parents:
8236
diff
changeset
|
28 assert.are.equal(true, configmanager.set("*", "set_test", "testkey", 123), "Setting a global value"); |
8236
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
29 end); |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
30 end); |
4878e4159e12
Port tests to the `busted` test runner
Waqas Hussain <waqas20@gmail.com>
parents:
diff
changeset
|
31 end); |