Software /
code /
prosody
Annotate
spec/net_http_server_spec.lua @ 12187:94253e02d47d
mod_http: Limit unencrypted http port (5280) to loopback by default
Since accessing this port directly over the wider Internet is unlikely
to intentional anymore. Most uses will likely be by reverse proxies, by
mistake or because of trouble configuring HTTPS.
Blocking mistaken uses is just a good thing, letting users send
potentially private things unencrypted tends to be Strongly Discouraged
these days.
Many reverse proxy setups operate over loopback, so listening there
instead of all interfaces is a net improvement.
Improved automatic certificate location and SNI support has mostly
eliminated the need for manual certificate configuration so HTTPS should
Just Work once certificates have been provided.
For local testing during development, connecting over loopback is likely
fine as well. When really needed, `http_interfaces` can still be set.
Suggested by Link Mauve
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sat, 15 Jan 2022 15:13:41 +0100 |
parent | 8687:ee01578c67cb |
rev | line source |
---|---|
8413
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 describe("net.http.server", function () |
8687
ee01578c67cb
net.http.server: Prevent loading of net.server in tests (breaks unrelated tests for some reason)
Kim Alvefur <zash@zash.se>
parents:
8413
diff
changeset
|
2 package.loaded["net.server"] = {} |
8413
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 local server = require "net.http.server"; |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 describe("events", function () |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 it("should work with util.helpers", function () |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 -- See #1044 |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 server.add_handler("GET host/foo/*", function () end, 0); |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 server.add_handler("GET host/foo/bar", function () end, 0); |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 local helpers = require "util.helpers"; |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
10 assert.is.string(helpers.show_events(server._events)); |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
11 end); |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
12 end); |
9a234e25b35b
spec/net.http.server: Add test for #1044
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 end); |