Annotate

HACKERS @ 8791:8da11142fabf

muc: Allow clients to change multiple affiliations or roles at once (#345) According to XEP-0045 sections 9.2, 9.5 and 9.8 affiliation lists and role lists should allow mass-modification. Prosody however would just use the first entry of the list and ignore the rest. This is fixed by introducing a `for` loop to `set` stanzas of the respective `muc#admin` namespace. In order for this loop to work, the error handling was changed a little. Prosody no longer returns after the first error. Instead, an error reply is sent for each malformed or otherwise wrong entry, but the loop keeps going over the other entries. This may lead to multiple error messages being sent for one client request. A notable exception from this is when the XML Schema for `muc#admin` requests is violated. In that case the loop is aborted with an error message to the client. The change is a bit bigger than that in order to have the loop only for `set` stanzas without changing the behaviour of the `get` stanzas. This is now more in line with trunk, where there are separate methods for each stanza type. References: #345
author Lennart Sauerbeck <devel@lennart.sauerbeck.org>
date Sat, 18 Mar 2017 18:47:28 +0100
parent 2664:33651e3f68b2
child 7359:a5a080c12c96
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 Welcome hackers!
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
3 This project accepts and *encourages* contributions. If you would like to get
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
4 involved you can join us on our mailing list and discussion rooms. More
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
5 information on these at http://prosody.im/discuss
13
716632cca05d Coding style doc, HACKERS file
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6
1082
f58394b9ba66 Word-wrap HACKERS file
Matthew Wild <mwild1@gmail.com>
parents: 527
diff changeset
7 Patches are welcome, though before sending we would appreciate if you read
2664
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
8 docs/coding_style.txt for guidelines on how to format your code, and other tips.
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
9
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
10 Documentation for developers can be found at http://prosody.im/doc/developers
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
11
33651e3f68b2 HACKERS: Update
Matthew Wild <mwild1@gmail.com>
parents: 1082
diff changeset
12 Have fun :)